media/mojo/interfaces/service_factory.mojom - Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/interfaces/service_factory.mojom

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Add implementation to use audio_device_id in CastRender. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/media/media_pipeline_backend_factory.h ('K') | « content/renderer/media/media_interface_provider.cc ('k') | media/mojo/services/media_mojo_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/interfaces/service_factory.mojom

diff --git a/media/mojo/interfaces/service_factory.mojom b/media/mojo/interfaces/service_factory.mojom

index b55e284c226d2b321e52f0344897742237d34bd4..0ef1445753ce3e6785c0716ad70b0fe527dad21a 100644

--- a/media/mojo/interfaces/service_factory.mojom

+++ b/media/mojo/interfaces/service_factory.mojom

@@ -19,7 +19,11 @@ interface ServiceFactory {

CreateVideoDecoder(VideoDecoder& video_decoder);

// Creates a Renderer service.

- CreateRenderer(Renderer& renderer);

+ // Audio stream will be played on device_id, which is defined in

+ // media/audio/audio_device_description.h. If audio_device_id

+ // is empty, kDefaultDeviceId will be used.

+ CreateRenderer(Renderer& renderer,

alokp 2016/07/12 05:01:30 nit: Input parameters should be placed before the

tianyuwang1 2016/07/12 15:28:09 Done.

+ string audio_device_id);

// Creates a ContentDecryptionModule service.

CreateCdm(ContentDecryptionModule& cdm);