chromecast/browser/media/media_pipeline_backend_factory.h - Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/browser/media/media_pipeline_backend_factory.h

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Add implementation to use audio_device_id in CastRender. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromecast/browser/media/cast_renderer.cc ('K') | « chromecast/browser/media/cast_renderer.cc ('k') | chromecast/browser/media/media_pipeline_host.cc » ('j') | media/mojo/interfaces/service_factory.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROMECAST_BROWSER_MEDIA_MEDIA_PIPELINE_BACKEND_FACTORY_H_	5 #ifndef CHROMECAST_BROWSER_MEDIA_MEDIA_PIPELINE_BACKEND_FACTORY_H_

6 #define CHROMECAST_BROWSER_MEDIA_MEDIA_PIPELINE_BACKEND_FACTORY_H_	6 #define CHROMECAST_BROWSER_MEDIA_MEDIA_PIPELINE_BACKEND_FACTORY_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "base/callback.h"	10 #include "base/callback.h"

11 #include "chromecast/public/media/media_pipeline_backend.h"	11 #include "chromecast/public/media/media_pipeline_backend.h"

12 #include "chromecast/public/media/media_pipeline_device_params.h"	12 #include "chromecast/public/media/media_pipeline_device_params.h"

13	13

14 namespace chromecast {	14 namespace chromecast {

15 namespace media {	15 namespace media {

16	16

17 typedef base::Callback<std::unique_ptr<MediaPipelineBackend>(	17 typedef base::Callback<std::unique_ptr<MediaPipelineBackend>(

18 const MediaPipelineDeviceParams&)>	18 const MediaPipelineDeviceParams&,

19 CreateMediaPipelineBackendCB;	19 int stream_type)> CreateMediaPipelineBackendCB;
	kmackay 2016/07/12 05:20:31 I think it would be better to take the device ID s I think it would be better to take the device ID string here rather than an integer stream type. Then we can do the mapping as appropriate in CastContentBrowserClientInternal. tianyuwang1 2016/07/12 15:28:09 Done. Show quoted text On 2016/07/12 05:20:31, kmackay wrote: > I think it would be better to take the device ID string here rather than an > integer stream type. Then we can do the mapping as appropriate in > CastContentBrowserClientInternal. Done.
20	20

21 } // media	21 } // media

22 } // chromecast	22 } // chromecast

23	23

24 #endif // CHROMECAST_BROWSER_MEDIA_MEDIA_PIPELINE_BACKEND_FACTORY_H_	24 #endif // CHROMECAST_BROWSER_MEDIA_MEDIA_PIPELINE_BACKEND_FACTORY_H_

OLD	NEW