Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2015893002: Add self to API_OWNERS and OWNERS (Closed)

Created:
4 years, 7 months ago by foolip
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, dglazkov
CC:
abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, fs, gasubic, haraken, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add self to API_OWNERS and OWNERS This mirrors https://codereview.chromium.org/1919183004 except that web-platform-tests/ and mediasource/ are left with their new owners. Also stay out of core/layout/OWNERS, where I ended up based on commit count in https://codereview.chromium.org/625053003 Committed: https://crrev.com/2a3069f5f5cb2ec02c5be124378f12b7ba5eb983 Cr-Commit-Position: refs/heads/master@{#396204}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort API_OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/API_OWNERS View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
foolip
4 years, 7 months ago (2016-05-26 09:36:53 UTC) #1
chrishtr
lgtm Welcome back as foolip sir! https://codereview.chromium.org/2015893002/diff/1/third_party/WebKit/API_OWNERS File third_party/WebKit/API_OWNERS (right): https://codereview.chromium.org/2015893002/diff/1/third_party/WebKit/API_OWNERS#newcode8 third_party/WebKit/API_OWNERS:8: tkent@chromium.org Reorder for ...
4 years, 7 months ago (2016-05-26 15:05:02 UTC) #3
foolip
Thanks Chris! https://codereview.chromium.org/2015893002/diff/1/third_party/WebKit/API_OWNERS File third_party/WebKit/API_OWNERS (right): https://codereview.chromium.org/2015893002/diff/1/third_party/WebKit/API_OWNERS#newcode8 third_party/WebKit/API_OWNERS:8: tkent@chromium.org On 2016/05/26 15:05:01, chrishtr wrote: > ...
4 years, 7 months ago (2016-05-26 15:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015893002/20001
4 years, 7 months ago (2016-05-26 15:58:16 UTC) #8
chrishtr
On 2016/05/26 at 15:57:39, foolip wrote: > Thanks Chris! > > https://codereview.chromium.org/2015893002/diff/1/third_party/WebKit/API_OWNERS > File third_party/WebKit/API_OWNERS ...
4 years, 7 months ago (2016-05-26 15:58:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 17:03:07 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 17:05:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a3069f5f5cb2ec02c5be124378f12b7ba5eb983
Cr-Commit-Position: refs/heads/master@{#396204}

Powered by Google App Engine
This is Rietveld 408576698