Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1919183004: Drop self from API_OWNERS, OWNERS, etc. (Closed)

Created:
4 years, 7 months ago by philipj_slow
Modified:
4 years, 7 months ago
CC:
tkent, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, mlamouri (slow - plz ping), pdr+renderingwatchlist_chromium.org, nessy, szager+layoutwatch_chromium.org, vcarbune.chromium, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop self from API_OWNERS, OWNERS, etc. tkent@ takes over web-platform-tests/dom and chcunningham@ joins wolenetz@ in mediasource/OWNERS. Committed: https://crrev.com/c8e42b0a1c8fcd6389738414543f21ec5b2f4aed Cr-Commit-Position: refs/heads/master@{#390604}

Patch Set 1 #

Total comments: 5

Patch Set 2 : tkent+chcunningham #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M WATCHLISTS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/API_OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
philipj_slow
Last week at Opera, can I have an lgtm on this so that I can ...
4 years, 7 months ago (2016-04-27 14:07:45 UTC) #4
Rick Byers
Grudgingly LGTM :-( https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode212 third_party/WebKit/LayoutTests/W3CImportExpectations:212: ## Owners: TBD tkent has been ...
4 years, 7 months ago (2016-04-27 14:31:08 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-27 14:34:20 UTC) #7
philipj_slow
https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode212 third_party/WebKit/LayoutTests/W3CImportExpectations:212: ## Owners: TBD On 2016/04/27 14:31:08, Rick Byers wrote: ...
4 years, 7 months ago (2016-04-27 14:43:33 UTC) #9
tkent
https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode212 third_party/WebKit/LayoutTests/W3CImportExpectations:212: ## Owners: TBD On 2016/04/27 at 14:43:33, philipj_slow wrote: ...
4 years, 7 months ago (2016-04-27 16:02:49 UTC) #10
wolenetz
I don't have a strong suggestion for an MSE modules co-owner: https://codereview.chromium.org/1919183004/diff/1/third_party/WebKit/Source/modules/mediasource/OWNERS File third_party/WebKit/Source/modules/mediasource/OWNERS (left): ...
4 years, 7 months ago (2016-04-27 20:18:57 UTC) #11
wolenetz
On 2016/04/27 20:18:57, wolenetz wrote: > I don't have a strong suggestion for an MSE ...
4 years, 7 months ago (2016-04-27 21:23:33 UTC) #13
philipj_slow
On 2016/04/27 21:23:33, wolenetz wrote: > On 2016/04/27 20:18:57, wolenetz wrote: > > I don't ...
4 years, 7 months ago (2016-04-28 09:37:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919183004/20001
4 years, 7 months ago (2016-04-29 08:17:46 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 09:18:55 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:41 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8e42b0a1c8fcd6389738414543f21ec5b2f4aed
Cr-Commit-Position: refs/heads/master@{#390604}

Powered by Google App Engine
This is Rietveld 408576698