Add finer-grained owners files

Add finer-grained owners files

This patch adds finer-grained owners files for seven sub-directories of
Source/core and bootstraps them with the top owner contributors from the
past year [1]. A discussion of this can be found on blink-dev [2]. An
emeritus section has been added to core/OWNERS to signify less active
reviewers, though no entries have been removed.

[1] https://docs.google.com/a/chromium.org/spreadsheets/d/13DgGH9jbcHO5yRTOIYs6LBW5C1vDXYccrKfK6hbm7DE/edit#gid=0
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/StkI3k4Pm5U/i5PdztzMgNMJ

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183511

[eseidel, 2014-10-06 19:16:15]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2014-10-06 19:16:16]

Could you speak more to what the goal of this change is?  Presumably to make it
easier to find the right reviewers?

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS
File Source/core/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS#newco...
Source/core/OWNERS:64: darin@chromium.org
I doubt darin@ will complain if you remove him.  He has plenty of ways to get
code into Blink if he needs.

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS#newco...
Source/core/OWNERS:66: # Owners emeritus:
Just remove these, we can always add them back later.

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
File Source/core/animation/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
Source/core/animation/OWNERS:2: dstockwell@chromium.org
I would just pick one person for new OWNERS files.  Let that one person build
out a larger list as necessary.

[leviw_travelin_and_unemployed, 2014-10-06 19:27:02]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2014-10-06 19:27:03]

I think there are a couple orthogonal goals here. One is to make it easier to
find owners. Another is to make it easier to attain more granular ownership (if
someone ramps up on Accessibility, it'll be much easier to get them ownership of
that than core).

I also have a secret hope that this may be a subtle nudge toward defining better
boundaries/apis between the different parts of Blink

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS
File Source/core/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS#newco...
Source/core/OWNERS:66: # Owners emeritus:
On 2014/10/06 19:16:16, eseidel wrote:
> Just remove these, we can always add them back later.

I believe he was mostly attempting to avoid a bikeshedding discussion about
removing old owners.

[eae, 2014-10-09 20:17:02]

eae@chromium.org changed reviewers:
+ eae@chromium.org

[eae, 2014-10-09 20:17:03]

LGTM

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
File Source/core/animation/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
Source/core/animation/OWNERS:2: dstockwell@chromium.org
On 2014/10/06 19:16:16, eseidel wrote:
> I would just pick one person for new OWNERS files.  Let that one person build
> out a larger list as necessary.

Bootstrapping with the most prolific comitters/reviewers seems reasonable and is
what we did for Source/wtf and Source/platform.

[leviw_travelin_and_unemployed, 2014-10-09 20:20:45]

LGTM2, and I'm fine with the notion of bootstrapping these files.

[dstockwell, 2014-10-09 21:57:01]

dstockwell@chromium.org changed reviewers:
+ dstockwell@chromium.org

[dstockwell, 2014-10-09 21:57:02]

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
File Source/core/animation/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
Source/core/animation/OWNERS:2: dstockwell@chromium.org
On 2014/10/09 at 20:17:03, eae wrote:
> On 2014/10/06 19:16:16, eseidel wrote:
> > I would just pick one person for new OWNERS files.  Let that one person
build
> > out a larger list as necessary.
> 
> Bootstrapping with the most prolific comitters/reviewers seems reasonable and
is what we did for Source/wtf and Source/platform.

This list is currently only sourced from core/OWNERS, I would expect the list
including committers would look quite different. But this is fine for now.

It's fun to see steveblock here, as he sadly hasn't been involved in Blink since
the end of 2013.

[pdr., 2014-10-10 02:56:25]

The CQ bit was checked by pdr@chromium.org

[pdr., 2014-10-10 02:56:26]

Thank you all for your help in making this happen!

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS
File Source/core/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/OWNERS#newco...
Source/core/OWNERS:66: # Owners emeritus:
On 2014/10/06 at 19:27:03, leviw wrote:
> On 2014/10/06 19:16:16, eseidel wrote:
> > Just remove these, we can always add them back later.
> 
> I believe he was mostly attempting to avoid a bikeshedding discussion about
removing old owners.

Yeah, this is the case. I think it would be healthy to prune the list but I
didn't want to mix these issues.

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
File Source/core/animation/OWNERS (right):

https://codereview.chromium.org/625053003/diff/60001/Source/core/animation/OW...
Source/core/animation/OWNERS:2: dstockwell@chromium.org
On 2014/10/09 at 21:57:02, dstockwell wrote:
> On 2014/10/09 at 20:17:03, eae wrote:
> > On 2014/10/06 19:16:16, eseidel wrote:
> > > I would just pick one person for new OWNERS files.  Let that one person
build
> > > out a larger list as necessary.
> > 
> > Bootstrapping with the most prolific comitters/reviewers seems reasonable
and is what we did for Source/wtf and Source/platform.
> 
> This list is currently only sourced from core/OWNERS, I would expect the list
including committers would look quite different. But this is fine for now.
> 
> It's fun to see steveblock here, as he sadly hasn't been involved in Blink
since the end of 2013.

I've removed Steve from the animation/owners the latest patch (he is still in
core/owners for the reason above). I double-checked his numbers though and he
was quite prolific in his last two months!

[commit-bot: I haz the power, 2014-10-10 02:57:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/625053003/130001

[ojan, 2014-10-10 04:01:06]

https://codereview.chromium.org/625053003/diff/130001/Source/core/OWNERS
File Source/core/OWNERS (right):

https://codereview.chromium.org/625053003/diff/130001/Source/core/OWNERS#newc...
Source/core/OWNERS:63: darin@chromium.org
Should these be commented out?

[pdr., 2014-10-10 04:05:04]

https://codereview.chromium.org/625053003/diff/130001/Source/core/OWNERS
File Source/core/OWNERS (right):

https://codereview.chromium.org/625053003/diff/130001/Source/core/OWNERS#newc...
Source/core/OWNERS:63: darin@chromium.org
On 2014/10/10 at 04:01:06, ojan-only-code-yellow-reviews wrote:
> Should these be commented out?

I'd like to remove them completely but as a separate effort.

[commit-bot: I haz the power, 2014-10-10 04:08:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 04:08:14]

Failed to apply patch for Source/core/OWNERS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/OWNERS
  Hunk #1 FAILED at 1.
  Hunk #2 succeeded at 4 (offset -1 lines).
  Hunk #3 succeeded at 15 (offset -1 lines).
  Hunk #4 succeeded at 28 (offset -2 lines).
  Hunk #5 succeeded at 53 (offset -2 lines).
  1 out of 5 hunks FAILED -- saving rejects to file Source/core/OWNERS.rej

Patch:       Source/core/OWNERS
Index: Source/core/OWNERS
diff --git a/Source/core/OWNERS b/Source/core/OWNERS
index
9c29240cfa2513f5c46b076889602262fd3b29c9..e053d0851bb5b074a386edc23af314a5a2be6a11
100644
--- a/Source/core/OWNERS
+++ b/Source/core/OWNERS
@@ -1,3 +1,6 @@
+# Please prefer to use more specific OWNERS if possible.
+# For example, core/rendering/OWNERS for rendering changes.
+
 abarth@chromium.org
 adamk@chromium.org
 ager@chromium.org
@@ -5,14 +8,10 @@ alexis.menard@intel.com
 apavlov@chromium.org
 arv@chromium.org
 chrishtr@chromium.org
-darin@chromium.org
 dcheng@chromium.org
 dglazkov@chromium.org
-dimich@chromium.org
-dmazzoni@chromium.org
 dominicc@chromium.org
 dpranke@chromium.org
-dschulze@chromium.org
 dstockwell@chromium.org
 eae@chromium.org
 enne@chromium.org
@@ -20,7 +19,6 @@ eseidel@chromium.org
 esprehn@chromium.org
 fmalita@chromium.org
 fs@opera.com
-hamaji@chromium.org
 haraken@chromium.org
 hayato@chromium.org
 inferno@chromium.org
@@ -35,11 +33,11 @@ keishi@chromium.org
 kenneth.r.christiansen@intel.com
 kinuko@chromium.org
 kouhei@chromium.org
-levin@chromium.org
 leviw@chromium.org
 mkwst@chromium.org
 morrita@chromium.org
 ojan@chromium.org
+# pdr reviews many svg and text autosizing patches.
 pdr@chromium.org
 pfeldman@chromium.org
 philipj@opera.com
@@ -60,3 +58,10 @@ vsevik@chromium.org
 yoav@yoav.ws
 yurys@chromium.org
 yutak@chromium.org
+
+# Owners emeritus:
+darin@chromium.org
+levin@chromium.org
+dimich@chromium.org
+dschulze@chromium.org
+hamaji@chromium.org
\ No newline at end of file

[commit-bot: I haz the power, 2014-10-10 04:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[pdr., 2014-10-10 04:17:25]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-10-10 04:18:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/625053003/310001

[commit-bot: I haz the power, 2014-10-10 05:21:48]

Committed patchset #6 (id:310001) as 183511