Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1850)

Unified Diff: content/renderer/media/android/renderer_media_session_manager.cc

Issue 2015433003: Implement MediaMetadata artwork in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed nits, added TODOs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/renderer_media_session_manager.cc
diff --git a/content/renderer/media/android/renderer_media_session_manager.cc b/content/renderer/media/android/renderer_media_session_manager.cc
index b5331c7472a30cacc4582ef5b350b0a0c67a6615..7a06f7a6b29a62c8a6edc111bee1c03f7c48d2ec 100644
--- a/content/renderer/media/android/renderer_media_session_manager.cc
+++ b/content/renderer/media/android/renderer_media_session_manager.cc
@@ -73,6 +73,8 @@ void RendererMediaSessionManager::SetMetadata(
metadata.artist.substr(0, MediaMetadata::kMaxIPCStringLength);
ipc_metadata.album =
metadata.album.substr(0, MediaMetadata::kMaxIPCStringLength);
+ // TODO(zqzhang): apply sanity checks on artwork?
palmer 2016/06/14 22:06:31 Yes, please. :) For example, is the src valid? (Wh
Zhiqiang Zhang (Slow) 2016/06/20 18:26:49 Now I'm doing sanity checks (is_valid(), IsStandar
+ ipc_metadata.artwork = metadata.artwork;
Send(new MediaSessionHostMsg_SetMetadata(routing_id(),
session_id,

Powered by Google App Engine
This is Rietveld 408576698