Implement MediaMetadata artwork in content

content/renderer/media/android/renderer_media_session_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/android/renderer_media_session_manager.h"
 
 #include "base/logging.h"
 #include "content/common/media/media_session_messages_android.h"
 #include "content/public/common/media_metadata.h"
 #include "content/public/renderer/render_thread.h"
@@ skipping 55 matching lines @@
     int session_id,
     const MediaMetadata& metadata) {
   // Apply some sanity checks on the MediaMetadata before sending over IPC.
   MediaMetadata ipc_metadata;
   ipc_metadata.title =
       metadata.title.substr(0, MediaMetadata::kMaxIPCStringLength);
   ipc_metadata.artist =
       metadata.artist.substr(0, MediaMetadata::kMaxIPCStringLength);
   ipc_metadata.album =
       metadata.album.substr(0, MediaMetadata::kMaxIPCStringLength);
+  // TODO(zqzhang): apply sanity checks on artwork?

[palmer, 2016/06/14 22:06:31]

Yes, please. :) For example, is the src valid? (What is it supposed to be? A
URL? If so, are there aspects of the URL you can check for, such as is it
parseable, does it use an approved scheme (e.g. not telnet: or mailto:), et c.?)

Similarly, are its sizes reasonable? A rectangle that is 2 billion x 2 billion
pixels is probably questionable, for example. That kind of thing.

[Zhiqiang Zhang (Slow), 2016/06/20 18:26:49]

Now I'm doing sanity checks (is_valid(), IsStandard(), SchemeIsHttpOrHttps(),
SchemeIsFile()).

For type, I'm just truncating the string if it's too long.

For sizes, I'm removing the sizes that are negative or too large.

+  ipc_metadata.artwork = metadata.artwork;
 
   Send(new MediaSessionHostMsg_SetMetadata(routing_id(),
                                            session_id,
                                            ipc_metadata));
 }
 
 void RendererMediaSessionManager::OnDidActivate(int request_id, bool success) {
   DCHECK(pending_activation_requests_.Lookup(request_id)) << request_id;
   blink::WebMediaSessionActivateCallback* callback =
       pending_activation_requests_.Lookup(request_id);
   if (success) {
     callback->onSuccess();
   } else {
     callback->onError(
         blink::WebMediaSessionError(blink::WebMediaSessionError::Activate));
   }
   pending_activation_requests_.Remove(request_id);
 }
 
 void RendererMediaSessionManager::OnDidDeactivate(int request_id) {
   DCHECK(pending_deactivation_requests_.Lookup(request_id)) << request_id;
   pending_deactivation_requests_.Lookup(request_id)->onSuccess();
   pending_deactivation_requests_.Remove(request_id);
 }
 
 }  // namespace content