Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2569)

Unified Diff: content/renderer/media/android/webmediasession_android.cc

Issue 2015433003: Implement MediaMetadata artwork in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed nits, added TODOs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediasession_android.cc
diff --git a/content/renderer/media/android/webmediasession_android.cc b/content/renderer/media/android/webmediasession_android.cc
index c1a936d1e25c6b70a24dd21cf26fdc57c03a66dd..d13576f5f149cda03354911c62eac3665d461633 100644
--- a/content/renderer/media/android/webmediasession_android.cc
+++ b/content/renderer/media/android/webmediasession_android.cc
@@ -10,6 +10,8 @@
#include "base/memory/ptr_util.h"
#include "content/public/common/media_metadata.h"
#include "content/renderer/media/android/renderer_media_session_manager.h"
+#include "third_party/WebKit/public/platform/WebIconSizesParser.h"
+#include "third_party/WebKit/public/platform/WebSize.h"
#include "third_party/WebKit/public/platform/modules/mediasession/WebMediaMetadata.h"
namespace content {
@@ -42,6 +44,14 @@ void WebMediaSessionAndroid::setMetadata(
metadata.title = web_metadata->title;
metadata.artist = web_metadata->artist;
metadata.album = web_metadata->album;
+ for (const auto& web_artwork : web_metadata->artwork) {
+ MediaMetadata::Artwork artwork;
+ artwork.src = GURL(base::string16(web_artwork.src));
palmer 2016/06/14 22:06:32 Right, so it's a URL. Let's check that basic GURL
Zhiqiang Zhang (Slow) 2016/06/20 18:26:49 Done. See the other reply for details.
+ artwork.type = web_artwork.type;
+ blink::WebVector<blink::WebSize> web_sizes =
+ blink::WebIconSizesParser::parseIconSizes(web_artwork.sizes);
+ std::copy(web_sizes.begin(), web_sizes.end(), artwork.sizes.begin());
+ }
}
session_manager_->SetMetadata(media_session_id_, metadata);

Powered by Google App Engine
This is Rietveld 408576698