Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015363003: Yet more ApplicationDelegate -> ApplicationImplBase conversion. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work797-x-work796_no_run_main_app
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Yet more ApplicationDelegate -> ApplicationImplBase conversion. Almost there. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a02505467f01880befaf0b32a25b97975b47a726

Patch Set 1 #

Patch Set 2 : fix tests? #

Patch Set 3 : take 2 #

Patch Set 4 : maybe a bit better? #

Patch Set 5 : rebased #

Patch Set 6 : rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -195 lines) Patch
M apps/benchmark/benchmark_app.cc View 1 2 3 4 5 8 chunks +18 lines, -18 lines 0 comments Download
M examples/echo/echo_benchmark.cc View 6 chunks +25 lines, -28 lines 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M examples/trace_me/trace_me_app.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M mojo/application/run_application.cc View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M services/debugger/debugger.cc View 5 chunks +15 lines, -19 lines 0 comments Download
M services/gfx/compositor/compositor_app.h View 1 chunk +5 lines, -7 lines 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M services/gfx/compositor/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M services/http_server/http_server_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_manager_app.h View 1 chunk +5 lines, -8 lines 0 comments Download
M services/ui/input_manager/input_manager_app.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M services/ui/input_manager/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M services/ui/launcher/launch_instance.h View 1 2 3 4 3 chunks +3 lines, -7 lines 0 comments Download
M services/ui/launcher/launch_instance.cc View 1 2 3 4 1 chunk +2 lines, -9 lines 0 comments Download
M services/ui/launcher/launcher_app.h View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 2 3 4 7 chunks +17 lines, -21 lines 0 comments Download
M services/ui/launcher/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M services/ui/view_manager/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M services/ui/view_manager/view_manager_app.h View 2 chunks +5 lines, -6 lines 0 comments Download
M services/ui/view_manager/view_manager_app.cc View 3 chunks +8 lines, -15 lines 0 comments Download

Dependent Patchsets:

Issue 2010283006 Patch 120001

Messages

Total messages: 6 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2020453003/, kind of. (Definitely depends on https://codereview.chromium.org/2011383002/.)
4 years, 6 months ago (2016-05-27 21:10:07 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-05-31 20:13:12 UTC) #2
viettrungluu
On 2016/05/31 20:13:12, viettrungluu wrote: > ping ping again
4 years, 6 months ago (2016-05-31 22:51:52 UTC) #3
vardhan
lgtm
4 years, 6 months ago (2016-05-31 23:22:18 UTC) #4
viettrungluu
4 years, 6 months ago (2016-05-31 23:35:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
a02505467f01880befaf0b32a25b97975b47a726 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698