Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010283006: Almost done: ApplicationDelegate -> ApplicationImplBase conversion. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work798-x-work797-x-work796_no_run_main_app
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Done-ish?: ApplicationDelegate -> ApplicationImplBase conversion. Still have to delete ApplicationDelegate, but I think uses are all gone. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/73e948c3cd78ca019b82d8ad10c2326e3920fffc

Patch Set 1 #

Patch Set 2 : eff it #

Patch Set 3 : format #

Patch Set 4 : clean up includes #

Patch Set 5 : moar #

Patch Set 6 : rebased #

Patch Set 7 : rebased again #

Patch Set 8 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -201 lines) Patch
M examples/native_run_app/native_run_app.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download
M mojo/application/content_handler_factory.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/common/trace_provider_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/tracing_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/platform/native/platform_handle_private_apptest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/flog/cpp/flog.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/gfx/composition/cpp/frame_tracker_apptest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/gfx/images/cpp/image_pipe_apptest.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M mojo/ui/associates/view_inspector_client_apptest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/ui/associates/view_tree_hit_tester_client_apptest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/dart/content_handler_app.h View 1 4 chunks +7 lines, -8 lines 0 comments Download
M services/dart/content_handler_app.cc View 1 4 chunks +15 lines, -15 lines 0 comments Download
M services/dart/content_handler_app_service_connector.h View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M services/dart/content_handler_app_service_connector.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M services/dart/dart_tracing.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M services/gfx/compositor/tests/scheduling_apptest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/java_handler/java_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M services/java_handler/java_handler.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M services/js/pingpong_apptest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M services/js/test/js_application_test_base.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/log/log_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/media/factory_service/audio_track_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M services/media/factory_service/audio_track_controller.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M services/media/factory_service/factory_service.h View 2 chunks +2 lines, -5 lines 0 comments Download
M services/media/factory_service/factory_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/media/factory_service/main.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M services/media/factory_service/media_player_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/media/factory_service/media_player_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/factory_service/media_sink_impl.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M services/media/factory_service/media_sink_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/factory_service/network_reader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/framework/parts/reader.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/view_manager/tests/view_manager_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/ui/view_manager/view_associate_table.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M services/util/cpp/factory_service_base.h View 1 2 3 4 5 6 7 4 chunks +5 lines, -15 lines 0 comments Download
M services/util/cpp/factory_service_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M shell/android/android_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
M shell/android/android_handler.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M shell/android/android_handler_loader.h View 2 chunks +0 lines, -4 lines 0 comments Download
M shell/android/android_handler_loader.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M shell/android/native_viewport_application_loader.h View 3 chunks +4 lines, -9 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 15 chunks +23 lines, -35 lines 0 comments Download
M shell/context.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M shell/url_response_disk_cache_loader.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
viettrungluu
Depends-ish on https://codereview.chromium.org/2015363003/.
4 years, 6 months ago (2016-05-27 23:17:32 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-05-31 22:52:03 UTC) #3
vardhan
lgtm
4 years, 6 months ago (2016-05-31 23:35:49 UTC) #4
viettrungluu
4 years, 6 months ago (2016-05-31 23:42:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as
73e948c3cd78ca019b82d8ad10c2326e3920fffc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698