Get rid of {Run,Terminate}MainApplication(), and more ApplicationDelegate conversion.

Get rid of {Run,Terminate}MainApplication(), and more ApplicationDelegate conversion.

Why RunMainApplication() was a bad idea:
 1. The intention is to allow the use of //base, which often requires
    some initialization (e.g., having an AtExitManager).
 2. But your ApplicationImplBase implementation would be created before
    that initialization (so using //base in its constructor would be
    dodgy).
 3. And it would be destroyed after, e.g., the AtExitManager was torn
    down (so using //base in its destructor -- or in the destructor of
    any member variable of your ApplicationImplBase implementation -- is
    potentially problematic).
So, instead just have a ScopedChromiumInit class, to make that stuff
explicit, and make the "scopes" not overlap.

Note that ApplicationRunnerChromium had a similar problem: Your
ApplicationDelegate implementation would be created before that
initialization (like 2.). However, the ApplicationImpl would destroy
your ApplicationDelegate implementation before tearing down the
AtExitManager, so it didn't have problem 3. (exactly). Nonetheless, it
was kind of horrible (since you couldn't really use //base in your
MojoMain()).

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/911b5de92406e7644cc15f457039e57629788508

[viettrungluu, 2016-05-27 18:24:59]

This change isn't really quite as big as it looks (though it's still
unfortunately a little hefty).

The files that are "+1 line, -1 line" are just RunMainApplication ->
RunApplication changes.

[viettrungluu, 2016-05-31 16:52:40]

ping

[vardhan, 2016-05-31 18:25:42]

lgtm

[viettrungluu, 2016-05-31 19:19:23]

Description was changed from

==========
Get rid of {Run,Terminate}MainApplication(), and more ApplicationDelegate
conversion.

Why RunMainApplication() was a bad idea:
 1. The intention is to allow the use of //base, which often requires
    some initialization (e.g., having an AtExitManager).
 2. But your ApplicationImplBase implementation would be created before
    that initialization (so using //base in its constructor would be
    dodgy).
 3. And it would be destroyed after, e.g., the AtExitManager was torn
    down (so using //base in its destructor -- or in the destructor of
    any member variable of your ApplicationImplBase implementation -- is
    potentially problematic).
So, instead just have a ScopedChromiumInit class, to make that stuff
explicit, and make the "scopes" not overlap.

Note that ApplicationRunnerChromium had a similar problem: Your
ApplicationDelegate implementation would be created before that
initialization (like 2.). However, the ApplicationImpl would destroy
your ApplicationDelegate implementation before tearing down the
AtExitManager, so it didn't have problem 3. (exactly). Nonetheless, it
was kind of horrible (since you couldn't really use //base in your
MojoMain()).

R=vardhan@google.com
==========

to

==========
Get rid of {Run,Terminate}MainApplication(), and more ApplicationDelegate
conversion.

Why RunMainApplication() was a bad idea:
 1. The intention is to allow the use of //base, which often requires
    some initialization (e.g., having an AtExitManager).
 2. But your ApplicationImplBase implementation would be created before
    that initialization (so using //base in its constructor would be
    dodgy).
 3. And it would be destroyed after, e.g., the AtExitManager was torn
    down (so using //base in its destructor -- or in the destructor of
    any member variable of your ApplicationImplBase implementation -- is
    potentially problematic).
So, instead just have a ScopedChromiumInit class, to make that stuff
explicit, and make the "scopes" not overlap.

Note that ApplicationRunnerChromium had a similar problem: Your
ApplicationDelegate implementation would be created before that
initialization (like 2.). However, the ApplicationImpl would destroy
your ApplicationDelegate implementation before tearing down the
AtExitManager, so it didn't have problem 3. (exactly). Nonetheless, it
was kind of horrible (since you couldn't really use //base in your
MojoMain()).

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/911b5de92406e7644cc15f45703...
==========

[viettrungluu, 2016-05-31 19:19:25]

Committed patchset #2 (id:20001) manually as
911b5de92406e7644cc15f457039e57629788508 (presubmit successful).