Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2015223002: MacViews: Fixed BrowserViewTest.CloseWithTabsStartWithActive. (Closed)

Created:
4 years, 6 months ago by kirr
Modified:
4 years, 6 months ago
Reviewers:
tapted, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fixed BrowserViewTest.CloseWithTabsStartWithActive. Fixed the DCHECK failure in NativeViewHostMac::AttachNativeView. NatiweWidgetMac::CloseNow() destroys |bridge_| object immidiately, but DestroyBrowserWebContents and NativeViewHostMac assumed that all view classes is alive. Call DestroyBrowserWebContents() earlier and unify it with aura, by moving it to BrowserView::OnWidgetDestroying. BUG= Committed: https://crrev.com/0a1c7e074d0d7171c1692a9e70239999ffc5b1fd Cr-Commit-Position: refs/heads/master@{#397346}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Removed handler from BrowserFrameAsh. Nits. #

Total comments: 4

Patch Set 3 : Remove DestroyBrowserWebContents. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -59 lines) Patch
M chrome/browser/ui/views/frame/browser_frame_ash.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.cc View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mac.mm View 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_shutdown.h View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_shutdown.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
kirr
PTAL. There was a DCHECK in browser_tests with following stack trace: * frame #0: 0x00000001162d12a6 ...
4 years, 6 months ago (2016-05-27 13:55:24 UTC) #2
tapted
This seems like a nice refactor. But we need to take care - the `DestroyBrowserWebContents` ...
4 years, 6 months ago (2016-05-30 23:43:55 UTC) #3
kirr
Thanks for detailed review. I saw https://codereview.chromium.org/154633003, but I don't have a permissions to see ...
4 years, 6 months ago (2016-05-31 12:11:44 UTC) #4
tapted
lgtm, but sky might see something I've missed.. https://codereview.chromium.org/2015223002/diff/20001/chrome/browser/ui/views/frame/browser_frame_ash.cc File chrome/browser/ui/views/frame/browser_frame_ash.cc (right): https://codereview.chromium.org/2015223002/diff/20001/chrome/browser/ui/views/frame/browser_frame_ash.cc#newcode17 chrome/browser/ui/views/frame/browser_frame_ash.cc:17: #include ...
4 years, 6 months ago (2016-05-31 12:38:44 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015223002/20001
4 years, 6 months ago (2016-05-31 14:10:16 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 15:54:54 UTC) #9
kirr
https://codereview.chromium.org/2015223002/diff/20001/chrome/browser/ui/views/frame/browser_frame_ash.cc File chrome/browser/ui/views/frame/browser_frame_ash.cc (right): https://codereview.chromium.org/2015223002/diff/20001/chrome/browser/ui/views/frame/browser_frame_ash.cc#newcode17 chrome/browser/ui/views/frame/browser_frame_ash.cc:17: #include "chrome/browser/ui/views/frame/browser_shutdown.h" On 2016/05/31 12:38:43, tapted wrote: > nit: ...
4 years, 6 months ago (2016-05-31 16:04:29 UTC) #10
sky
On 2016/05/31 16:04:29, kirr wrote: > https://codereview.chromium.org/2015223002/diff/20001/chrome/browser/ui/views/frame/browser_frame_ash.cc > File chrome/browser/ui/views/frame/browser_frame_ash.cc (right): > > https://codereview.chromium.org/2015223002/diff/20001/chrome/browser/ui/views/frame/browser_frame_ash.cc#newcode17 > ...
4 years, 6 months ago (2016-05-31 19:28:28 UTC) #11
kirr
On 2016/05/31 19:28:28, sky wrote: > Yes. One question though. It seems like your patch ...
4 years, 6 months ago (2016-06-01 10:12:45 UTC) #12
sky
LGTM
4 years, 6 months ago (2016-06-01 15:30:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015223002/40001
4 years, 6 months ago (2016-06-02 08:25:45 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 09:21:42 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:22:46 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a1c7e074d0d7171c1692a9e70239999ffc5b1fd
Cr-Commit-Position: refs/heads/master@{#397346}

Powered by Google App Engine
This is Rietveld 408576698