Attempt at fixing possible shutdown crash

Attempt at fixing possible shutdown crash

In some situations we can enter ~BrowserView with WebContents in the
tab strip. There is code that attempted to deal with this, but by the
time we get to ~BrowserView it's really too late to attempt to delete
the WebContents. Reason being doing anything with the TabStrip more
often than not results in calling back to the BrowserView and related
classes. So, this shutdown really needs to be done earlier on.

I'm moving it to when the frame is being destroyed, which means all
view/layout classes are still valid.

BUG=176556
TEST=covered by test now.
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249083

[sky, 2014-02-05 00:01:05]

https://codereview.chromium.org/154633003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/frame/browser_shutdown.h (right):

https://codereview.chromium.org/154633003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/frame/browser_shutdown.h:2: // Use of this source code
is governed by a BSD-style license that can be
I'm not thrilled about putting this in a new file, but I like it better than yet
another member of BrowserView. If you have a better place let me know.

[Ben Goodger (Google), 2014-02-05 00:45:54]

lgtm

[sky, 2014-02-05 00:59:28]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-02-05 03:53:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/154633003/20001

[commit-bot: I haz the power, 2014-02-05 08:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-05 08:38:52]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[sky, 2014-02-05 17:21:00]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-02-05 17:23:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/154633003/360001

[commit-bot: I haz the power, 2014-02-05 19:40:10]

Change committed as 249083