MacViews: Fixed BrowserViewTest.CloseWithTabsStartWithActive.

chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/desktop_browser_frame_aura.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/views/frame/browser_desktop_window_tree_host.h"
-#include "chrome/browser/ui/views/frame/browser_shutdown.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/aura/window_observer.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/gfx/font.h"
 #include "ui/views/view.h"
@@ skipping 18 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // DesktopBrowserFrameAura, protected:
 
 DesktopBrowserFrameAura::~DesktopBrowserFrameAura() {
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // DesktopBrowserFrameAura, views::DesktopNativeWidgetAura overrides:
 
 void DesktopBrowserFrameAura::OnHostClosed() {
-  // Destroy any remaining WebContents early on. Doing so may result in
-  // calling back to one of the Views/LayoutManagers or supporting classes of
-  // BrowserView. By destroying here we ensure all said classes are valid.
-  DestroyBrowserWebContents(browser_view_->browser());
   aura::client::SetVisibilityClient(GetNativeView()->GetRootWindow(), nullptr);
   DesktopNativeWidgetAura::OnHostClosed();
 }
 
 void DesktopBrowserFrameAura::InitNativeWidget(
     const views::Widget::InitParams& params) {
   browser_desktop_window_tree_host_ =
       BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost(
           browser_frame_,
           this,
           browser_view_,
           browser_frame_);
   views::Widget::InitParams modified_params = params;
   modified_params.desktop_window_tree_host =
       browser_desktop_window_tree_host_->AsDesktopWindowTreeHost();
   DesktopNativeWidgetAura::InitNativeWidget(modified_params);
 
   visibility_controller_.reset(new wm::VisibilityController);

[tapted, 2016/05/30 23:43:55]

hm - I wonder if there's a way to make this obsolete -- the
DesktopNativeWidgetAura::InitNativeWidget(..) call just above does something
very similar when initialized with `Widget::InitParams::TRANSLUCENT_WINDOW`. The
OnHostClosed() override (and the entire hook) could probably be eliminated as
well. Maybe something for a follow-up - there's probably a good reason it's done
this way.

   aura::client::SetVisibilityClient(GetNativeView()->GetRootWindow(),
                                     visibility_controller_.get());
   wm::SetChildWindowVisibilityChangesAnimated(
       GetNativeView()->GetRootWindow());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopBrowserFrameAura, NativeBrowserFrame implementation:
 
 views::Widget::InitParams DesktopBrowserFrameAura::GetWidgetParams() {
@@ skipping 23 matching lines @@
     gfx::Rect* bounds,
     ui::WindowShowState* show_state) const {
   *bounds = GetWidget()->GetRestoredBounds();
   if (IsMaximized())
     *show_state = ui::SHOW_STATE_MAXIMIZED;
   else if (IsMinimized())
     *show_state = ui::SHOW_STATE_MINIMIZED;
   else
     *show_state = ui::SHOW_STATE_NORMAL;
 }