Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2014323002: Use std::unique_ptr<base::Value> in V8ValueConverter. (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::unique_ptr<base::Value> in V8ValueConverter. More ownership with less comments! BUG=581865 Committed: https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1 Cr-Commit-Position: refs/heads/master@{#396504}

Patch Set 1 #

Patch Set 2 : android fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -143 lines) Patch
M android_webview/renderer/aw_message_port_client.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M content/child/v8_value_converter_impl.h View 2 chunks +14 lines, -13 lines 0 comments Download
M content/child/v8_value_converter_impl.cc View 16 chunks +53 lines, -43 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 14 chunks +26 lines, -29 lines 0 comments Download
M content/public/child/v8_value_converter.h View 6 chunks +13 lines, -10 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.cc View 1 3 chunks +16 lines, -15 lines 0 comments Download
M content/renderer/web_ui_extension.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M extensions/renderer/script_injection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
dcheng
+nick for //content and overall review +thestig for //chrome OWNERS +rockot for //extensions OWNERS
4 years, 7 months ago (2016-05-26 19:42:26 UTC) #2
ncarter (slow)
lgtm
4 years, 7 months ago (2016-05-26 19:57:32 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-26 20:05:36 UTC) #4
Lei Zhang
You got red bots.
4 years, 7 months ago (2016-05-26 20:22:05 UTC) #5
Lei Zhang
chrome/ lgtm though
4 years, 7 months ago (2016-05-26 20:22:42 UTC) #6
dcheng
+torne for android fixes in //android_webview and //content/renderer/java
4 years, 7 months ago (2016-05-26 20:47:31 UTC) #8
Torne
LGTM
4 years, 6 months ago (2016-05-27 10:01:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014323002/20001
4 years, 6 months ago (2016-05-27 17:42:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 17:47:55 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:49:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0232f57400b65505a27db30b1de5e918bf2481b1
Cr-Commit-Position: refs/heads/master@{#396504}

Powered by Google App Engine
This is Rietveld 408576698