Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3535)

Unified Diff: chrome/renderer/extensions/cast_streaming_native_handler.cc

Issue 2014323002: Use std::unique_ptr<base::Value> in V8ValueConverter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/renderer/aw_message_port_client.cc ('k') | content/child/v8_value_converter_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/cast_streaming_native_handler.cc
diff --git a/chrome/renderer/extensions/cast_streaming_native_handler.cc b/chrome/renderer/extensions/cast_streaming_native_handler.cc
index 2834540b941124f951f702eb4f0bc7c106a70dd5..c03f63fc5607ae012e854405569efef0f9a5d0d0 100644
--- a/chrome/renderer/extensions/cast_streaming_native_handler.cc
+++ b/chrome/renderer/extensions/cast_streaming_native_handler.cc
@@ -509,16 +509,14 @@ void CastStreamingNativeHandler::SetOptionsCastUdpTransport(
return;
std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
- base::Value* options_value =
- converter->FromV8Value(args[1], context()->v8_context());
- base::DictionaryValue* options;
- if (!options_value || !options_value->GetAsDictionary(&options)) {
- delete options_value;
+ std::unique_ptr<base::DictionaryValue> options = base::DictionaryValue::From(
+ converter->FromV8Value(args[1], context()->v8_context()));
+ if (!options) {
args.GetIsolate()->ThrowException(v8::Exception::TypeError(
v8::String::NewFromUtf8(args.GetIsolate(), kUnableToConvertArgs)));
return;
}
- transport->SetOptions(base::WrapUnique(options));
+ transport->SetOptions(std::move(options));
}
void CastStreamingNativeHandler::ToggleLogging(
« no previous file with comments | « android_webview/renderer/aw_message_port_client.cc ('k') | content/child/v8_value_converter_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698