Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: content/child/v8_value_converter_impl.h

Issue 2014323002: Use std::unique_ptr<base::Value> in V8ValueConverter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/v8_value_converter_impl.h
diff --git a/content/child/v8_value_converter_impl.h b/content/child/v8_value_converter_impl.h
index fd23c47a7e28b358ddac6e52b73646f40c6a6ac1..4b4c00afe4023b424782f71a5074175670765ddc 100644
--- a/content/child/v8_value_converter_impl.h
+++ b/content/child/v8_value_converter_impl.h
@@ -34,8 +34,9 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {
v8::Local<v8::Value> ToV8Value(
const base::Value* value,
v8::Local<v8::Context> context) const override;
- base::Value* FromV8Value(v8::Local<v8::Value> value,
- v8::Local<v8::Context> context) const override;
+ std::unique_ptr<base::Value> FromV8Value(
+ v8::Local<v8::Value> value,
+ v8::Local<v8::Context> context) const override;
private:
friend class ScopedAvoidIdentityHashForTesting;
@@ -57,21 +58,21 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {
v8::Local<v8::Object> creation_context,
const base::BinaryValue* value) const;
- base::Value* FromV8ValueImpl(FromV8ValueState* state,
- v8::Local<v8::Value> value,
- v8::Isolate* isolate) const;
- base::Value* FromV8Array(v8::Local<v8::Array> array,
- FromV8ValueState* state,
- v8::Isolate* isolate) const;
+ std::unique_ptr<base::Value> FromV8ValueImpl(FromV8ValueState* state,
+ v8::Local<v8::Value> value,
+ v8::Isolate* isolate) const;
+ std::unique_ptr<base::Value> FromV8Array(v8::Local<v8::Array> array,
+ FromV8ValueState* state,
+ v8::Isolate* isolate) const;
// This will convert objects of type ArrayBuffer or any of the
// ArrayBufferView subclasses.
- base::Value* FromV8ArrayBuffer(v8::Local<v8::Object> val,
- v8::Isolate* isolate) const;
+ std::unique_ptr<base::Value> FromV8ArrayBuffer(v8::Local<v8::Object> val,
+ v8::Isolate* isolate) const;
- base::Value* FromV8Object(v8::Local<v8::Object> object,
- FromV8ValueState* state,
- v8::Isolate* isolate) const;
+ std::unique_ptr<base::Value> FromV8Object(v8::Local<v8::Object> object,
+ FromV8ValueState* state,
+ v8::Isolate* isolate) const;
// If true, we will convert Date JavaScript objects to doubles.
bool date_allowed_;
« no previous file with comments | « chrome/renderer/extensions/cast_streaming_native_handler.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698