Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 2014213002: Replace FXJSE_HCLASS with CFXJSE_Class* (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@fxjse_hcontext
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FXJSE_HCLASS with CFXJSE_Class* This CL removes FXJSE_HCLASS and replaces with CFXJSE_Class*. All variables have been updated to the new type. Committed: https://pdfium.googlesource.com/pdfium/+/e9885e77a7daf7a8d45eaf0290a1ea5f208c24c6

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Patch Set 4 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxjse/cfxjse_arguments.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/class.cpp View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxjse/value.cpp View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-26 13:48:53 UTC) #3
Tom Sepez
Great. LGTM. https://codereview.chromium.org/2014213002/diff/20001/xfa/fxfa/fm2js/xfa_fm2jscontext.h File xfa/fxfa/fm2js/xfa_fm2jscontext.h (right): https://codereview.chromium.org/2014213002/diff/20001/xfa/fxfa/fm2js/xfa_fm2jscontext.h#newcode449 xfa/fxfa/fm2js/xfa_fm2jscontext.h:449: FXJSE_CLASS m_fmClass; follow-up: We gotta get better ...
4 years, 7 months ago (2016-05-26 15:40:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014213002/60001
4 years, 7 months ago (2016-05-26 16:48:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_xfa on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/builds/798)
4 years, 7 months ago (2016-05-26 16:50:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014213002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014213002/80001
4 years, 7 months ago (2016-05-26 16:52:41 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 17:14:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/e9885e77a7daf7a8d45eaf0290a1ea5f208c...

Powered by Google App Engine
This is Rietveld 408576698