Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2012253002: Remove FXJSE_HOBJECT and FXJSE_HVALUE for CFXJSE_Value* (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@fxjse_hclass
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FXJSE_HOBJECT and FXJSE_HVALUE for CFXJSE_Value* This CL replaces FXJSE_HOBJECT and FXJSE_HVALUE with the concrete CFXJSE_Value* type. All variables are renamed to match. Committed: https://pdfium.googlesource.com/pdfium/+/12a6b0c1bb3ab86a03a84464bed168995ae0d82a

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebase to master #

Patch Set 3 : Merge to master #

Patch Set 4 : Rebase to master #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1890 lines, -1940 lines) Patch
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 3 chunks +8 lines, -14 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 2 chunks +4 lines, -7 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/javascript/ijs_runtime.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jsapi.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jsapi.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 8 chunks +129 lines, -128 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 170 chunks +891 lines, -891 lines 0 comments Download
M xfa/fxfa/include/fxfa.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/include/fxfa_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/fxfa_widget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/include/xfa_ffdochandler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 11 chunks +66 lines, -66 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 63 chunks +200 lines, -200 lines 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 1 chunk +14 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 2 chunks +17 lines, -17 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 3 chunks +58 lines, -58 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.h View 2 chunks +15 lines, -15 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 25 chunks +73 lines, -73 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 4 chunks +21 lines, -21 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 2 3 4 21 chunks +115 lines, -114 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 12 chunks +31 lines, -31 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M xfa/fxjse/cfxjse_arguments.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxjse/class.cpp View 1 2 6 chunks +8 lines, -14 lines 0 comments Download
M xfa/fxjse/context.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M xfa/fxjse/dynprop.cpp View 7 chunks +22 lines, -33 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 2 3 chunks +53 lines, -55 lines 0 comments Download
M xfa/fxjse/value.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/value.cpp View 1 2 7 chunks +90 lines, -117 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-26 15:40:18 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/2012253002/diff/20001/xfa/fxfa/parser/xfa_script_imp.cpp File xfa/fxfa/parser/xfa_script_imp.cpp (left): https://codereview.chromium.org/2012253002/diff/20001/xfa/fxfa/parser/xfa_script_imp.cpp#oldcode222 xfa/fxfa/parser/xfa_script_imp.cpp:222: (CXFA_ScriptContext*)pOrginalObject->GetDocument()->GetScriptContext(); nice.
4 years, 7 months ago (2016-05-26 15:51:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012253002/80001
4 years, 7 months ago (2016-05-26 17:18:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_xfa on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/806)
4 years, 7 months ago (2016-05-26 17:30:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012253002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012253002/100001
4 years, 7 months ago (2016-05-26 17:59:27 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:14:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/12a6b0c1bb3ab86a03a84464bed168995ae0...

Powered by Google App Engine
This is Rietveld 408576698