xfa/fxfa/fm2js/xfa_fm2jscontext.h - Issue 2014213002: Replace FXJSE_HCLASS with CFXJSE_Class*

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxfa/fm2js/xfa_fm2jscontext.h

Issue 2014213002: Replace FXJSE_HCLASS with CFXJSE_Class* (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@fxjse_hcontext

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_	7 #ifndef XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_

8 #define XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_	8 #define XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_

9	9

10 #include "xfa/fxfa/parser/xfa_script.h"	10 #include "xfa/fxfa/parser/xfa_script.h"

(...skipping 428 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
439 CFXJSE_Context* pScriptContext,	439 CFXJSE_Context* pScriptContext,

440 CXFA_Document* pDoc);	440 CXFA_Document* pDoc);

441 void GlobalPropertyGetter(FXJSE_HVALUE hValue);	441 void GlobalPropertyGetter(FXJSE_HVALUE hValue);

442	442

443 v8::Isolate* GetScriptRuntime() const { return m_pIsolate; }	443 v8::Isolate* GetScriptRuntime() const { return m_pIsolate; }

444 CXFA_Document* GetDocument() const { return m_pDocument; }	444 CXFA_Document* GetDocument() const { return m_pDocument; }

445 void ThrowScriptErrorMessage(int32_t iStringID, ...);	445 void ThrowScriptErrorMessage(int32_t iStringID, ...);

446	446

447 private:	447 private:

448 v8::Isolate* m_pIsolate;	448 v8::Isolate* m_pIsolate;

449 FXJSE_CLASS m_fmClass;	449 FXJSE_CLASS m_fmClass;
	Tom Sepez 2016/05/26 15:40:43 follow-up: We gotta get better names here FXJSE_C follow-up: We gotta get better names here FXJSE_CLASS and CFXJSE_CLASS are too close to each other as are m_fmClass and m_pFMClass. Goodness.
450 FXJSE_HCLASS m_hFMClass;	450 CFXJSE_Class* m_pFMClass;

451 FXJSE_HVALUE m_hValue;	451 FXJSE_HVALUE m_hValue;

452 CXFA_Document* m_pDocument;	452 CXFA_Document* m_pDocument;

453 };	453 };

454	454

455 #endif // XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_	455 #endif // XFA_FXFA_FM2JS_XFA_FM2JSCONTEXT_H_

OLD	NEW