third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

index 42a147dd3abcf29f53e19130d2a5e94d551d1889..24a15473ff2020b25aeaf06b57a3415283b84798 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

@@ -85,8 +85,10 @@ class CrashLogsTest(unittest.TestCase):

files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06-13-150719_quadzen.crash'] = mock_crash_report

files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06-13-150720_quadzen.crash'] = newer_mock_crash_report

files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06-13-150721_quadzen.crash'] = None

- files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06-13-150722_quadzen.crash'] = other_process_mock_crash_report

- files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06-13-150723_quadzen.crash'] = misformatted_mock_crash_report

+ files['/Users/mock/Library/Logs/DiagnosticReports/'

+ 'DumpRenderTree_2011-06-13-150722_quadzen.crash'] = other_process_mock_crash_report

+ files['/Users/mock/Library/Logs/DiagnosticReports/'

+ 'DumpRenderTree_2011-06-13-150723_quadzen.crash'] = misformatted_mock_crash_report

mithro 2016/06/01 01:01:42 These two lines probably shouldn't be wrapped. You

qyearsley 2016/06/01 21:24:22 Done.

filesystem = MockFileSystem(files)

crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))

log = crash_logs.find_newest_log("DumpRenderTree")