third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

index 41bb16de21147d78f1348e5ac27a72f42c3f7b8d..6aaec6f90d0ece893b1c4e90b821335a5b545eaf 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

@@ -87,6 +87,7 @@ _PROCESSING_CHUNK = 3

class DiffFile(object):

"""Contains the information for one file in a patch.

qyearsley 2016/05/27 16:06:03 Blank line before class docstring is not necessari

Dirk Pranke 2016/06/01 00:06:47 I'm not particularly a fan of the blank line.

qyearsley 2016/06/01 21:24:22 Alright -- changed formatter/main.py to not add th

The field "lines" is a list which contains tuples in this format:

@@ -119,6 +120,7 @@ class DiffFile(object):

# If this is going to be called DiffParser, it should be a re-useable parser.

# Otherwise we should rename it to ParsedDiff or just Diff.

class DiffParser(object):

"""A parser for a patch file.

The field "files" is a dict whose key is the filename and value is