Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014003002: mojo/converters/input_events -> ui/events/mojo (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, tdresser+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@converters
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo/converters/input_events -> ui/events/mojo R=sky@chromium.org BUG= Committed: https://crrev.com/37a47f11fbde7d222fd184ec0bdf3df3e099851d Cr-Commit-Position: refs/heads/master@{#396182}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -642 lines) Patch
M ash/mus/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/event_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/platform_display.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/converters/input_events/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/converters/input_events/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/converters/input_events/input_events_type_converters.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/converters/input_events/input_events_type_converters.cc View 1 chunk +0 lines, -421 lines 0 comments Download
D mojo/converters/input_events/mojo_extended_key_event_data.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/converters/input_events/mojo_extended_key_event_data.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/converters/input_events/mojo_input_events_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
A + ui/events/mojo/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A + ui/events/mojo/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/mojo/input_events_type_converters.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/events/mojo/input_events_type_converters.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/events/mojo/mojo_extended_key_event_data.h View 2 chunks +6 lines, -5 lines 0 comments Download
A + ui/events/mojo/mojo_extended_key_event_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/events/mojo/mojo_input_events_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2009073003 Patch 60001

Dependent Patchsets:

Issue 2012113003 Patch 1
Issue 2012113003 Patch 20001
Issue 2012113003 Patch 40001

Messages

Total messages: 14 (8 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-25 20:59:47 UTC) #3
Ben Goodger (Google)
actually no mojoms here so removing tom.
4 years, 7 months ago (2016-05-25 21:00:24 UTC) #6
sky
Rubber stamp LGTM
4 years, 7 months ago (2016-05-25 21:13:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014003002/20001
4 years, 7 months ago (2016-05-26 13:16:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 15:34:17 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 15:37:04 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/37a47f11fbde7d222fd184ec0bdf3df3e099851d
Cr-Commit-Position: refs/heads/master@{#396182}

Powered by Google App Engine
This is Rietveld 408576698