Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012113003: mojo/converters/surfaces -> components/mus/public/cpp/surfaces (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, tfarina, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@converters_events
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo/converters/surfaces -> components/mus/public/cpp/surfaces R=sky@chromium.org BUG= Committed: https://crrev.com/5554eda51e730002333f6bb97d3a1d1c7ab3e180 Cr-Commit-Position: refs/heads/master@{#396236}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1674 lines) Patch
M components/bitmap_uploader/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/mus/public/cpp/surfaces/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
A + components/mus/public/cpp/surfaces/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/mus/public/cpp/surfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/mus/public/cpp/surfaces/custom_surface_converter.h View 2 chunks +6 lines, -3 lines 0 comments Download
A + components/mus/public/cpp/surfaces/mojo_surfaces_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/mus/public/cpp/surfaces/surfaces_type_converters.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/mus/public/cpp/surfaces/surfaces_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/mus/public/cpp/surfaces/surfaces_utils.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + components/mus/public/cpp/surfaces/tests/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 3 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/platform_display.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/server_window_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_server.h View 2 chunks +1 line, -1 line 0 comments Download
M components/mus/ws/window_server.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/converters/surfaces/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/converters/surfaces/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/converters/surfaces/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/converters/surfaces/custom_surface_converter.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/converters/surfaces/mojo_surfaces_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +0 lines, -160 lines 0 comments Download
D mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +0 lines, -635 lines 0 comments Download
D mojo/converters/surfaces/surfaces_utils.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/converters/surfaces/surfaces_utils.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/converters/surfaces/tests/surface_unittest.cc View 1 chunk +0 lines, -485 lines 0 comments Download
D mojo/converters/transform/BUILD.gn View 1 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/converters/transform/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/converters/transform/mojo_transform_export.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/converters/transform/transform_type_converters.h View 1 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/converters/transform/transform_type_converters.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/mojo/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/mojo/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/mojo/mojo_transform_export.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/mojo/transform_type_converters.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/mojo/transform_type_converters.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_binding.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2014003002 Patch 20001

Messages

Total messages: 13 (6 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-25 23:30:05 UTC) #1
sky
Rubber stamp LGTM
4 years, 7 months ago (2016-05-25 23:34:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012113003/20001
4 years, 6 months ago (2016-05-26 15:41:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/236156)
4 years, 6 months ago (2016-05-26 16:21:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012113003/40001
4 years, 6 months ago (2016-05-26 17:07:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-26 18:33:36 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 18:38:29 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5554eda51e730002333f6bb97d3a1d1c7ab3e180
Cr-Commit-Position: refs/heads/master@{#396236}

Powered by Google App Engine
This is Rietveld 408576698