Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2009073003: Move mojo/converters/geometry -> ui/gfx/geometry/mojo (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
Reviewers:
stgao, nodir, sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, creis+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move mojo/converters/geometry -> ui/gfx/geometry/mojo R=sky@chromium.org TBR=tsepez@chromium.org BUG= Committed: https://crrev.com/7a77e85c2dbd440d718702b2580109eabe422f22 Cr-Commit-Position: refs/heads/master@{#396128}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -592 lines) Patch
M ash/mus/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/gpu_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/compositor_frame.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/event_matcher.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/gpu_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/window_manager_constants.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/window_tree_host.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/surfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/test_wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/test_wm/test_wm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 5 chunks +6 lines, -6 lines 0 comments Download
M components/mus/ws/display.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/event_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/platform_display.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/mus/ws/server_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/test_change_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/test_utils.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_client_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/image_downloader/image_downloader.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M mash/example/views_examples/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/webtest/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/webtest/webtest.cc View 2 chunks +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/renderer.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/converters/geometry/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/converters/geometry/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/converters/geometry/geometry_type_converters.h View 1 chunk +0 lines, -102 lines 0 comments Download
D mojo/converters/geometry/geometry_type_converters.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D mojo/converters/geometry/mojo_geometry_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/converters/input_events/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/transform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/transform/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/transform/transform_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M services/navigation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/public/interfaces/view.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/mojo/BUILD.gn View 3 chunks +21 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/mojo/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/geometry/mojo/geometry.mojom View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/gfx/geometry/mojo/geometry_type_converters.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/geometry/mojo/geometry_type_converters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/geometry/mojo/geometry_util.h View 2 chunks +5 lines, -5 lines 0 comments Download
A ui/gfx/geometry/mojo/mojo_bindings.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
A + ui/gfx/geometry/mojo/mojo_geometry_export.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 2 chunks +40 lines, -0 lines 2 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/mojo/display/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/mojo/display/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/mojo/display/display_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/mojo/geometry/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/mojo/geometry/geometry.mojom View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/mojo/geometry/geometry_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/mojo/geometry/mojo_bindings.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-25 20:27:58 UTC) #4
sky
Rubber stamp LGTM
4 years, 7 months ago (2016-05-25 20:31:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009073003/40001
4 years, 7 months ago (2016-05-25 20:54:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/206547) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-25 21:02:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009073003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009073003/60001
4 years, 7 months ago (2016-05-25 23:04:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/206651)
4 years, 7 months ago (2016-05-25 23:46:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009073003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009073003/80001
4 years, 7 months ago (2016-05-26 00:02:01 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-26 05:50:57 UTC) #20
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/7a77e85c2dbd440d718702b2580109eabe422f22 Cr-Commit-Position: refs/heads/master@{#396128}
4 years, 7 months ago (2016-05-26 05:51:59 UTC) #22
nodir
This is probably a cause of https://bugs.chromium.org/p/chromium/issues/detail?id=615066 https://codereview.chromium.org/2009073003/diff/80001/ui/gfx/gfx.gyp File ui/gfx/gfx.gyp (right): https://codereview.chromium.org/2009073003/diff/80001/ui/gfx/gfx.gyp#newcode7 ui/gfx/gfx.gyp:7: '../../mojo/mojo_variables.gypi', should ...
4 years, 7 months ago (2016-05-26 17:57:57 UTC) #24
stgao
4 years, 7 months ago (2016-05-26 18:28:07 UTC) #26
Message was sent while issue was closed.
https://codereview.chromium.org/2009073003/diff/80001/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/2009073003/diff/80001/ui/gfx/gfx.gyp#newcode7
ui/gfx/gfx.gyp:7: '../../mojo/mojo_variables.gypi',
On 2016/05/26 17:57:57, nodir wrote:
> should be a list?

It seems this cause a lot of failures in lkgr.
https://build.chromium.org/p/chromium.lkgr/console

Powered by Google App Engine
This is Rietveld 408576698