Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issue 2013883003: Migrate UnlinkedVariable.constExpr to UnlinkedExecutable.bodyExpr. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate UnlinkedVariable.constExpr to UnlinkedExecutable.bodyExpr. To do AST-based type inference involving function closures, we will need to be able to store closure body expressions in unlinked summaries--this requires adding a `bodyExpr` field to UnlinkedExecutable. Since every UnlinkedVariable with a body expression has a corresponding UnlinkedExecutable representing its initializer, it makes sense to store the constant expression there for uniformity. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f1bd126241ffce75fd971610ac68d1a311e646c7

Patch Set 1 #

Patch Set 2 : Fix a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+892 lines, -735 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 29 chunks +67 lines, -67 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 5 chunks +18 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +9 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 135 chunks +772 lines, -620 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-25 21:33:19 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-25 22:01:03 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-25 22:22:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f1bd126241ffce75fd971610ac68d1a311e646c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698