Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 2013883003: Migrate UnlinkedVariable.constExpr to UnlinkedExecutable.bodyExpr. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix a comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.fbs ('k') | pkg/analyzer/lib/src/summary/link.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/idl.dart
diff --git a/pkg/analyzer/lib/src/summary/idl.dart b/pkg/analyzer/lib/src/summary/idl.dart
index 9679112389733138772b4af5699d275f61acefbd..de2ef5704bd44bdbbf32c6937de0760dc6dfe8d3 100644
--- a/pkg/analyzer/lib/src/summary/idl.dart
+++ b/pkg/analyzer/lib/src/summary/idl.dart
@@ -41,10 +41,11 @@
*/
library analyzer.tool.summary.idl;
+import 'package:analyzer/dart/element/element.dart';
+
import 'base.dart' as base;
import 'base.dart' show Id, TopLevel;
import 'format.dart' as generated;
-import 'package:analyzer/dart/element/element.dart';
/**
* Annotation describing information which is not part of Dart semantics; in
@@ -1469,13 +1470,6 @@ enum UnlinkedConstOperation {
*/
abstract class UnlinkedConstructorInitializer extends base.SummaryClass {
/**
- * If [kind] is `thisInvocation` or `superInvocation`, the arguments of the
- * invocation. Otherwise empty.
- */
- @Id(3)
- List<UnlinkedConst> get arguments;
-
- /**
* If there are `m` [arguments] and `n` [argumentNames], then each argument
* from [arguments] with index `i` such that `n + i - m >= 0`, should be used
* with the name at `n + i - m`.
@@ -1484,6 +1478,13 @@ abstract class UnlinkedConstructorInitializer extends base.SummaryClass {
List<String> get argumentNames;
/**
+ * If [kind] is `thisInvocation` or `superInvocation`, the arguments of the
+ * invocation. Otherwise empty.
+ */
+ @Id(3)
+ List<UnlinkedConst> get arguments;
+
+ /**
* If [kind] is `field`, the expression of the field initializer.
* Otherwise `null`.
*/
@@ -1637,6 +1638,14 @@ abstract class UnlinkedExecutable extends base.SummaryClass {
List<UnlinkedConst> get annotations;
/**
+ * If this executable's function body is declared using `=>`, the expression
+ * to the right of the `=>`. May be omitted if neither type inference nor
+ * constant evaluation depends on the function body.
+ */
+ @Id(29)
+ UnlinkedConst get bodyExpr;
+
+ /**
* Code range of the executable.
*/
@informative
@@ -2621,16 +2630,8 @@ abstract class UnlinkedVariable extends base.SummaryClass {
* Code range of the variable.
*/
@informative
- @Id(14)
- CodeRange get codeRange;
-
- /**
- * If [isConst] is true, and the variable has an initializer, the constant
- * expression in the initializer. Note that the presence of this expression
- * does not mean that it is a valid, check [UnlinkedConst.isInvalid].
- */
@Id(5)
- UnlinkedConst get constExpr;
+ CodeRange get codeRange;
/**
* Documentation comment for the variable, or `null` if there is no
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.fbs ('k') | pkg/analyzer/lib/src/summary/link.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698