Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: pkg/analyzer/lib/src/summary/format.fbs

Issue 2013883003: Migrate UnlinkedVariable.constExpr to UnlinkedExecutable.bodyExpr. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix a comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/lib/src/summary/idl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/format.fbs
diff --git a/pkg/analyzer/lib/src/summary/format.fbs b/pkg/analyzer/lib/src/summary/format.fbs
index 8df99fe44c184b25c925d51451103f40e93836de..92accd506b1ed15f0226bd4318b6770d63847e94 100644
--- a/pkg/analyzer/lib/src/summary/format.fbs
+++ b/pkg/analyzer/lib/src/summary/format.fbs
@@ -1472,12 +1472,6 @@ table UnlinkedConst {
*/
table UnlinkedConstructorInitializer {
/**
- * If [kind] is `thisInvocation` or `superInvocation`, the arguments of the
- * invocation. Otherwise empty.
- */
- arguments:[UnlinkedConst] (id: 3);
-
- /**
* If there are `m` [arguments] and `n` [argumentNames], then each argument
* from [arguments] with index `i` such that `n + i - m >= 0`, should be used
* with the name at `n + i - m`.
@@ -1485,6 +1479,12 @@ table UnlinkedConstructorInitializer {
argumentNames:[string] (id: 4);
/**
+ * If [kind] is `thisInvocation` or `superInvocation`, the arguments of the
+ * invocation. Otherwise empty.
+ */
+ arguments:[UnlinkedConst] (id: 3);
+
+ /**
* If [kind] is `field`, the expression of the field initializer.
* Otherwise `null`.
*/
@@ -1597,6 +1597,13 @@ table UnlinkedExecutable {
annotations:[UnlinkedConst] (id: 6);
/**
+ * If this executable's function body is declared using `=>`, the expression
+ * to the right of the `=>`. May be omitted if neither type inference nor
+ * constant evaluation depends on the function body.
+ */
+ bodyExpr:UnlinkedConst (id: 29);
+
+ /**
* Code range of the executable.
*/
codeRange:CodeRange (id: 26);
@@ -2296,14 +2303,7 @@ table UnlinkedVariable {
/**
* Code range of the variable.
*/
- codeRange:CodeRange (id: 14);
-
- /**
- * If [isConst] is true, and the variable has an initializer, the constant
- * expression in the initializer. Note that the presence of this expression
- * does not mean that it is a valid, check [UnlinkedConst.isInvalid].
- */
- constExpr:UnlinkedConst (id: 5);
+ codeRange:CodeRange (id: 5);
/**
* Documentation comment for the variable, or `null` if there is no
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/lib/src/summary/idl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698