Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2013763003: Change POST-exclusion to idempotent-inclusion (Closed)

Created:
4 years, 6 months ago by tbansal1
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Change POST-exclusion to idempotent-inclusion The data saver proxy should only be used for idempotent methods, but right now it only checks if the method is POST, which leaves out other non-idempotent methods like PATCH. Instead of excluding POST and PATCH, this will explicitly check if the method is GET, OPTIONS, HEAD, PUT, DELETE, or TRACE. BUG=614078 Review-Url: https://codereview.chromium.org/2001243002 Cr-Commit-Position: refs/heads/master@{#395502} (cherry picked from commit fbc93e59b496ff6ea423527d1a3579fa8a2d061c) Committed: https://chromium.googlesource.com/chromium/src/+/554bbbaa0daf530ff667372bc1db72dbe90f6b38

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
tbansal1
4 years, 6 months ago (2016-05-25 18:11:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
554bbbaa0daf530ff667372bc1db72dbe90f6b38.

Powered by Google App Engine
This is Rietveld 408576698