components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc - Issue 2013763003: Change POST-exclusion to idempotent-inclusion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc

Issue 2013763003: Change POST-exclusion to idempotent-inclusion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc ('k') | components/data_reduction_proxy/core/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc

index d1e9a4dce6f960cad651a80f67da19efd15a7d57..99b2951abc6120ff1c43e293ea927ad3eaa8ebdd 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc

@@ -14,6 +14,7 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_creator.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"

+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_util.h"

#include "net/base/host_port_pair.h"

#include "net/base/url_util.h"

#include "net/http/http_request_headers.h"

@@ -119,7 +120,7 @@ void OnResolveProxyHandler(const GURL& url,

bool data_saver_proxy_used = true;

if (result->is_empty() || !result->proxy_server().is_direct() ||

result->proxy_list().size() != 1 || url.SchemeIsWSOrWSS() ||

- method == "POST") {

+ !IsMethodIdempotent(method)) {

return;

}