components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 2013763003: Change POST-exclusion to idempotent-inclusion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 2013763003: Change POST-exclusion to idempotent-inclusion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index 03d183585af9d7df84ad341d0c6436e5e6801118..38b3e98644faec6c1d995021a3943753179f37b5 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -25,6 +25,7 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h"

+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_util.h"

#include "net/base/completion_callback.h"

#include "net/base/host_port_pair.h"

#include "net/base/load_flags.h"

@@ -343,9 +344,7 @@ TEST_F(DataReductionProxyProtocolTest, TestIdempotency) {

std::unique_ptr<net::URLRequest> request(context.CreateRequest(

GURL("http://www.google.com/"), net::DEFAULT_PRIORITY, NULL));

request->set_method(tests[i].method);

- EXPECT_EQ(

- tests[i].expected_result,

- DataReductionProxyBypassProtocol::IsRequestIdempotent(request.get()));

+ EXPECT_EQ(tests[i].expected_result, IsMethodIdempotent(request->method()));

}