Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2013523005: [Mac][Material Design] Bring bookmark hover state, etc. up to spec. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Bring bookmark hover state, etc. up to spec. This cl brings the bookmark hover state appearance in various places, the padding between buttons, and the layout of folder buttons within folder menus up to spec. R=avi@chromium.org BUG=613279, 615224, 615163, 613086 Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133 Cr-Commit-Position: refs/heads/master@{#396195} Committed: https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6 Cr-Commit-Position: refs/heads/master@{#396851}

Patch Set 1 #

Patch Set 2 : Fix regressions. #

Patch Set 3 : Fix typo, fix chevron button highlight state. #

Messages

Total messages: 18 (9 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-25 23:55:11 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-26 03:33:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013523005/1
4 years, 7 months ago (2016-05-26 15:50:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 16:32:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133 Cr-Commit-Position: refs/heads/master@{#396195}
4 years, 7 months ago (2016-05-26 16:33:44 UTC) #7
shrike
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2011173002/ by shrike@chromium.org. ...
4 years, 7 months ago (2016-05-26 20:58:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013523005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013523005/40001
4 years, 6 months ago (2016-05-31 16:22:19 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 17:14:42 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:15:46 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6
Cr-Commit-Position: refs/heads/master@{#396851}

Powered by Google App Engine
This is Rietveld 408576698