Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6420)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2013523005: [Mac][Material Design] Bring bookmark hover state, etc. up to spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo, fix chevron button highlight state. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index 07a92fa91475bf0f80eb74b31fe9fc2b8ca640e3..6996b954ab745ea27ed7adafeb09e68226208d21 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -255,7 +255,7 @@ CGFloat BookmarkHorizontalPadding() {
if (!ui::MaterialDesignController::IsModeMaterial()) {
return 1.0;
}
- return 10.0;
+ return 4.0;
}
CGFloat BookmarkVerticalPadding() {
@@ -486,6 +486,9 @@ CGFloat BookmarkRightMargin() {
BookmarkButtonCell* offTheSideCell = [offTheSideButton_ cell];
[offTheSideCell setTag:kMaterialStandardButtonTypeWithLimitedClickFeedback];
[offTheSideCell setImagePosition:NSImageOnly];
+
+ // The cell is configured in the nib to draw a white highlight when clicked.
+ [offTheSideCell setHighlightsBy:NSNoCellMask];
} else {
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
[offTheSideButton_ setImage:
@@ -510,6 +513,11 @@ CGFloat BookmarkRightMargin() {
originalImportBookmarksRect_.origin.x += kMaterialBookmarksTextfieldOffsetX;
[[buttonView_ importBookmarksButton] setFrame:originalImportBookmarksRect_];
+
+ // Move the chevron button up 2pts from its position in the xib.
+ NSRect chevronButtonFrame = [offTheSideButton_ frame];
+ chevronButtonFrame.origin.y -= 2;
+ [offTheSideButton_ setFrame:chevronButtonFrame];
}
// To make life happier when the bookmark bar is floating, the chevron is a
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698