Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

Issue 2013523005: [Mac][Material Design] Bring bookmark hover state, etc. up to spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo, fix chevron button highlight state. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
index a074dc20bd6c36fbf210c556f1fe7bfc1a6f88ca..ff6ba4b43f9382b4fc790246c3eea4528e3776e8 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
@@ -1284,8 +1284,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, MenuSizingAndScrollArrows) {
EXPECT_TRUE(folderController);
NSWindow* folderWindow = [folderController window];
EXPECT_TRUE(folderWindow);
- CGFloat expectedHeight = (CGFloat)bookmarks::kBookmarkFolderButtonHeight +
- (2*bookmarks::BookmarkVerticalPadding());
+ CGFloat expectedHeight =
+ (CGFloat)bookmarks::kBookmarkFolderButtonHeight +
+ bookmarks::BookmarkTopVerticalPadding() +
+ bookmarks::BookmarkBottomVerticalPadding();
NSRect windowFrame = [folderWindow frame];
CGFloat windowHeight = NSHeight(windowFrame);
EXPECT_CGFLOAT_EQ(expectedHeight, windowHeight);
@@ -1593,18 +1595,20 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DropPositionIndicator) {
EXPECT_TRUE(folder);
// Test a series of points starting at the top of the folder.
- const CGFloat yOffset = 0.5 * bookmarks::BookmarkVerticalPadding();
+ const CGFloat yTopOffset = 0.5 * bookmarks::BookmarkTopVerticalPadding();
+ const CGFloat yBottomOffset =
+ 0.5 * bookmarks::BookmarkBottomVerticalPadding();
BookmarkButton* targetButton = [folder buttonWithTitleEqualTo:@"2f1b"];
ASSERT_TRUE(targetButton);
NSPoint targetPoint = [targetButton top];
CGFloat pos = [folder indicatorPosForDragToPoint:targetPoint];
- EXPECT_CGFLOAT_EQ(targetPoint.y + yOffset, pos);
+ EXPECT_CGFLOAT_EQ(targetPoint.y + yTopOffset, pos);
pos = [folder indicatorPosForDragToPoint:[targetButton bottom]];
targetButton = [folder buttonWithTitleEqualTo:@"2f2f"];
- EXPECT_CGFLOAT_EQ([targetButton top].y + yOffset, pos);
+ EXPECT_CGFLOAT_EQ([targetButton top].y + yTopOffset, pos);
pos = [folder indicatorPosForDragToPoint:NSMakePoint(10,0)];
targetButton = [folder buttonWithTitleEqualTo:@"2f3b"];
- EXPECT_CGFLOAT_EQ([targetButton bottom].y - yOffset, pos);
+ EXPECT_CGFLOAT_EQ([targetButton bottom].y - yBottomOffset, pos);
}
@interface BookmarkBarControllerNoDelete : BookmarkBarController

Powered by Google App Engine
This is Rietveld 408576698