Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2013483002: headless: Make HeadlessBrowser::Options move-only (Closed)

Created:
4 years, 6 months ago by Sami
Modified:
4 years, 6 months ago
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Make HeadlessBrowser::Options move-only This patch turns HeadlessBrowser::Options into a move-only object. This makes it possible to later add move-only options (e.g., std::unique_ptr). BUG=595353 Committed: https://crrev.com/b5ee712010a665091eb525be87f47d0464621b6e Cr-Commit-Position: refs/heads/master@{#395867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -50 lines) Patch
M headless/lib/browser/headless_browser_context.h View 3 chunks +4 lines, -4 lines 0 comments Download
M headless/lib/browser/headless_browser_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/browser/headless_devtools.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.h View 2 chunks +8 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M headless/lib/headless_content_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/headless_content_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M headless/public/headless_browser.h View 3 chunks +7 lines, -3 lines 0 comments Download
M headless/public/headless_browser.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M headless/test/headless_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M headless/test/headless_browser_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M headless/test/headless_test_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 6 months ago (2016-05-24 18:29:46 UTC) #3
altimin
lgtm
4 years, 6 months ago (2016-05-25 10:35:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013483002/1
4 years, 6 months ago (2016-05-25 11:05:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 11:54:33 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 11:55:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5ee712010a665091eb525be87f47d0464621b6e
Cr-Commit-Position: refs/heads/master@{#395867}

Powered by Google App Engine
This is Rietveld 408576698