Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: headless/lib/browser/headless_browser_context.h

Issue 2013483002: headless: Make HeadlessBrowser::Options move-only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/lib/browser/headless_browser_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_browser_context.h
diff --git a/headless/lib/browser/headless_browser_context.h b/headless/lib/browser/headless_browser_context.h
index 865b3c7f9778b3c9417a95cbc6043a3b972fda48..91bff6525f8dc400c487f05f857aac27e7c80a4b 100644
--- a/headless/lib/browser/headless_browser_context.h
+++ b/headless/lib/browser/headless_browser_context.h
@@ -19,7 +19,7 @@ class HeadlessResourceContext;
class HeadlessBrowserContext : public content::BrowserContext {
public:
- explicit HeadlessBrowserContext(const HeadlessBrowser::Options& options);
+ explicit HeadlessBrowserContext(HeadlessBrowser::Options* options);
~HeadlessBrowserContext() override;
// BrowserContext implementation:
@@ -48,8 +48,8 @@ class HeadlessBrowserContext : public content::BrowserContext {
const base::FilePath& partition_path,
bool in_memory) override;
- const HeadlessBrowser::Options& options() const { return options_; }
- void SetOptionsForTesting(const HeadlessBrowser::Options& options);
+ HeadlessBrowser::Options* options() const { return options_; }
+ void SetOptionsForTesting(HeadlessBrowser::Options* options);
private:
// Performs initialization of the HeadlessBrowserContext while IO is still
@@ -58,7 +58,7 @@ class HeadlessBrowserContext : public content::BrowserContext {
base::FilePath path_;
std::unique_ptr<HeadlessResourceContext> resource_context_;
- HeadlessBrowser::Options options_;
+ HeadlessBrowser::Options* options_; // Not owned.
DISALLOW_COPY_AND_ASSIGN(HeadlessBrowserContext);
};
« no previous file with comments | « no previous file | headless/lib/browser/headless_browser_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698