headless/lib/browser/headless_browser_main_parts.cc - Issue 2013483002: headless: Make HeadlessBrowser::Options move-only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_browser_main_parts.cc

Issue 2013483002: headless: Make HeadlessBrowser::Options move-only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_browser_main_parts.cc

diff --git a/headless/lib/browser/headless_browser_main_parts.cc b/headless/lib/browser/headless_browser_main_parts.cc

index 7a2ed47f028c4a2051ba9b81c14940ef76aeb80c..9781e39905ca1d08b9ffda56a3981dde5e7c2cc6 100644

--- a/headless/lib/browser/headless_browser_main_parts.cc

+++ b/headless/lib/browser/headless_browser_main_parts.cc

@@ -33,7 +33,7 @@ HeadlessBrowserMainParts::~HeadlessBrowserMainParts() {}

void HeadlessBrowserMainParts::PreMainMessageLoopRun() {

browser_context_.reset(new HeadlessBrowserContext(browser_->options()));

- if (browser_->options().devtools_endpoint.address().IsValid()) {

+ if (browser_->options()->devtools_endpoint.address().IsValid()) {

devtools_http_handler_ =

CreateLocalDevToolsHttpHandler(browser_context_.get());

}