Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2013423002: Clean up recording of clicks for New tab page snippets (Closed)

Created:
4 years, 6 months ago by jkrcal
Modified:
4 years, 6 months ago
CC:
chromium-reviews, zine-eng+reviews_google.com, asvitkine+watch_chromium.org, mastiz
Base URL:
https://chromium.googlesource.com/chromium/src.git@snippets-impressions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up recording of clicks for New tab page snippets Clean up the code so that it aligns with the changes introduced in https://codereview.chromium.org/2006203002/ BUG=610687 Committed: https://crrev.com/71d3d0aac17f170cdb43664bac976802406a23ec Cr-Commit-Position: refs/heads/master@{#397128}

Patch Set 1 #

Patch Set 2 : Fixing a build problem #

Patch Set 3 : A minor fix #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #2 #

Patch Set 6 : Rebase #3 #

Patch Set 7 : Rebase #4 #

Patch Set 8 : Fixing a rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -53 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java View 1 2 6 chunks +45 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 2 3 4 5 6 7 6 chunks +4 lines, -50 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013423002/1
4 years, 6 months ago (2016-05-27 12:39:57 UTC) #2
jkrcal
Ted: PTAL at the .java files. Alexei: PTAL at histograms.xml
4 years, 6 months ago (2016-05-27 12:41:32 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/77872)
4 years, 6 months ago (2016-05-27 12:57:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013423002/20001
4 years, 6 months ago (2016-05-27 13:23:16 UTC) #8
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-05-27 13:47:03 UTC) #9
Ted C
lgtm
4 years, 6 months ago (2016-05-31 19:48:49 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013423002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013423002/80001
4 years, 6 months ago (2016-06-01 07:31:58 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/14110) ios-device-gn on ...
4 years, 6 months ago (2016-06-01 07:33:32 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013423002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013423002/120001
4 years, 6 months ago (2016-06-01 11:51:03 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/79755)
4 years, 6 months ago (2016-06-01 12:22:08 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013423002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013423002/140001
4 years, 6 months ago (2016-06-01 12:32:38 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 13:45:18 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013423002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013423002/140001
4 years, 6 months ago (2016-06-01 13:46:02 UTC) #25
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 6 months ago (2016-06-01 13:50:11 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:52:55 UTC) #28
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/71d3d0aac17f170cdb43664bac976802406a23ec
Cr-Commit-Position: refs/heads/master@{#397128}

Powered by Google App Engine
This is Rietveld 408576698