Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2016913004:
Track age and score of snippets that are shown (along with position). (Closed)
|
Created:
4 years, 6 months ago by jkrcal Modified:
4 years, 6 months ago CC:
chromium-reviews, zine-eng+reviews_google.com, asvitkine+watch_chromium.org, mastiz Base URL:
https://chromium.googlesource.com/chromium/src.git@snippets-clicks-retake Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrack age and score of snippets that are shown (along with position).
Following CL https://codereview.chromium.org/1996473002/ for clicks,
this CL adds tracking of age and score of snippets upon impression.
It also slightly expands and corrects the summary for the previous click-based histograms.
BUG=608365, 614309
Committed: https://crrev.com/cf58210ebaf042016907bd47332c823a6612078b
Cr-Commit-Position: refs/heads/master@{#397349}
Patch Set 1 #Patch Set 2 : A minor fix #Patch Set 3 : Rebase #Patch Set 4 : Rebase #2 #Patch Set 5 : Rebase #3 #
Messages
Total messages: 24 (12 generated)
jkrcal@chromium.org changed reviewers: + asvitkine@chromium.org, tedchoc@chromium.org
Ted: PTAL at the .java file. Alexei: PTAL at histograms.xml.
Description was changed from ========== Track age and score of snippets that are shown (along with position). Following CL https://codereview.chromium.org/1996473002/ for clicks, this CL adds tracking of age and score of snippets upon impression. BUG=608365,614309 ========== to ========== Track age and score of snippets that are shown (along with position). Following CL https://codereview.chromium.org/1996473002/ for clicks, this CL adds tracking of age and score of snippets upon impression. It also slightly expands and corrects the summary for the previous click-based histograms. BUG=608365,614309 ==========
lgtm
lgtm
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016913004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016913004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016913004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016913004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016913004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016913004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jkrcal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org, asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2016913004/#ps80001 (title: "Rebase #3")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016913004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016913004/80001
Message was sent while issue was closed.
Description was changed from ========== Track age and score of snippets that are shown (along with position). Following CL https://codereview.chromium.org/1996473002/ for clicks, this CL adds tracking of age and score of snippets upon impression. It also slightly expands and corrects the summary for the previous click-based histograms. BUG=608365,614309 ========== to ========== Track age and score of snippets that are shown (along with position). Following CL https://codereview.chromium.org/1996473002/ for clicks, this CL adds tracking of age and score of snippets upon impression. It also slightly expands and corrects the summary for the previous click-based histograms. BUG=608365,614309 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Track age and score of snippets that are shown (along with position). Following CL https://codereview.chromium.org/1996473002/ for clicks, this CL adds tracking of age and score of snippets upon impression. It also slightly expands and corrects the summary for the previous click-based histograms. BUG=608365,614309 ========== to ========== Track age and score of snippets that are shown (along with position). Following CL https://codereview.chromium.org/1996473002/ for clicks, this CL adds tracking of age and score of snippets upon impression. It also slightly expands and corrects the summary for the previous click-based histograms. BUG=608365,614309 Committed: https://crrev.com/cf58210ebaf042016907bd47332c823a6612078b Cr-Commit-Position: refs/heads/master@{#397349} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/cf58210ebaf042016907bd47332c823a6612078b Cr-Commit-Position: refs/heads/master@{#397349} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
