tools/metrics/histograms/histograms.xml - Issue 2013423002: Clean up recording of clicks for New tab page snippets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2013423002: Clean up recording of clicks for New tab page snippets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snippets-impressions

Patch Set: Fixing a rebase error Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index e1b3215a82ebe190cd13378ae9071d8138b69b05..67518f60ad50695907e3b59a59bc119fa529cd1e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -33957,7 +33957,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>knn@chromium.org</owner>

Android: The position of the snippets card on the NTP, that is clicked

- through to the host website of the content.

+ through to the host website of the content. We track the position the

+ snippet had in the list when NTP was loaded. This tracked position is thus

+ different from the position observed by the user whenever before scrolling

+ down to the given snippet, the user discards some snippets in the top of the

+ list.

</summary>

</histogram>

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java ('k') | no next file » | no next file with comments »