Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2013023002: Clean up CPDF_TextRenderer slightly. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@fxgeclean2
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean up CPDF_TextRenderer slightly. - Remove dead code - Remove default arguments - Move code into anonymous namespace Committed: https://pdfium.googlesource.com/pdfium/+/fd6cfad310187631554613c375ec1b4c5ef887a3

Patch Set 1 : #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -109 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 6 chunks +9 lines, -19 lines 0 comments Download
M core/fpdfapi/fpdf_render/include/cpdf_textrenderer.h View 4 chunks +4 lines, -21 lines 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 1 5 chunks +71 lines, -68 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Lei Zhang
https://codereview.chromium.org/2013023002/diff/40001/fpdfsdk/fxedit/fxet_pageobjs.cpp File fpdfsdk/fxedit/fxet_pageobjs.cpp (right): https://codereview.chromium.org/2013023002/diff/40001/fpdfsdk/fxedit/fxet_pageobjs.cpp#newcode97 fpdfsdk/fxedit/fxet_pageobjs.cpp:97: void AddRectToPageObjects(CPDF_PageObjectHolder* pObjectHolder, Just moved code over, no changes.
4 years, 7 months ago (2016-05-26 18:00:51 UTC) #4
dsinclair
lgtm
4 years, 7 months ago (2016-05-26 18:02:29 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2011943004 Patch 320001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-26 18:02:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013023002/40001
4 years, 7 months ago (2016-05-26 18:06:05 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:37:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/fd6cfad310187631554613c375ec1b4c5ef8...

Powered by Google App Engine
This is Rietveld 408576698