Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010813003: Remove default arguments from CFX_FxgeDevice. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@fxgeclean2_textrenderer
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove default arguments from CFX_FxgeDevice. Remove unused dithering code. Committed: https://pdfium.googlesource.com/pdfium/+/befa4506dc9d2a679c526aff96c09bcb0e9daecb

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : Remove Ex functions, more cleanup #

Patch Set 4 : Win? #

Patch Set 5 : nit #

Patch Set 6 : typo #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -336 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 2 8 chunks +5 lines, -29 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 2 5 chunks +14 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/render_int.h View 5 chunks +5 lines, -6 lines 0 comments Download
M core/fxge/agg/fx_agg_driver.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 1 2 5 chunks +5 lines, -11 lines 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -84 lines 0 comments Download
M core/fxge/ge/fx_ge_device.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/include/fx_dib.h View 2 chunks +4 lines, -7 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M core/fxge/skia/fx_skia_device.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 2 3 4 5 6 7 chunks +3 lines, -11 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 2 4 chunks +91 lines, -90 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 4 5 6 4 chunks +21 lines, -17 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_formtp.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OneDimWriter.cpp View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 1 2 7 chunks +12 lines, -10 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 1 2 6 chunks +12 lines, -9 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 2 3 4 8 chunks +15 lines, -14 lines 0 comments Download
M xfa/fxgraphics/cagg_graphics.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
Next CL going down the list in fx_ge.h... https://codereview.chromium.org/2010813003/diff/20001/core/fxge/include/fx_ge.h File core/fxge/include/fx_ge.h (right): https://codereview.chromium.org/2010813003/diff/20001/core/fxge/include/fx_ge.h#newcode406 core/fxge/include/fx_ge.h:406: bool ...
4 years, 7 months ago (2016-05-26 18:11:29 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/2010813003/diff/20001/core/fxge/include/fx_ge.h File core/fxge/include/fx_ge.h (right): https://codereview.chromium.org/2010813003/diff/20001/core/fxge/include/fx_ge.h#newcode406 core/fxge/include/fx_ge.h:406: bool AttachEx(CFX_DIBitmap* pBitmap, On 2016/05/26 18:11:29, Lei Zhang ...
4 years, 7 months ago (2016-05-26 18:26:14 UTC) #3
Lei Zhang
https://codereview.chromium.org/2010813003/diff/20001/core/fxge/include/fx_ge.h File core/fxge/include/fx_ge.h (right): https://codereview.chromium.org/2010813003/diff/20001/core/fxge/include/fx_ge.h#newcode406 core/fxge/include/fx_ge.h:406: bool AttachEx(CFX_DIBitmap* pBitmap, On 2016/05/26 18:26:14, dsinclair wrote: > ...
4 years, 7 months ago (2016-05-26 21:06:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010813003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010813003/120001
4 years, 6 months ago (2016-05-27 03:15:02 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 03:15:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/befa4506dc9d2a679c526aff96c09bcb0e9d...

Powered by Google App Engine
This is Rietveld 408576698