Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011943004: Remove default arguments in CFX_RenderDevice. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove default arguments in CFX_RenderDevice. Committed: https://pdfium.googlesource.com/pdfium/+/d3e354a43531eaed87e43d9ff2df4525186ea28d

Patch Set 1 : Remove default arguments, add Ex functions #

Patch Set 2 : Remove DrawNormalTextEx #

Patch Set 3 : Simplify StretchBitMaskEx #

Patch Set 4 : Simplify StretchDIBitsEx #

Patch Set 5 : Remove GetDIBitsEx #

Patch Set 6 : Simplify SetDIBitsEx #

Patch Set 7 : Remove SetBitMaskEx #

Patch Set 8 : Simplify StartDIBitsEx #

Patch Set 9 : Simplify DrawTextPathEx #

Patch Set 10 : Remove SetPixelEx #

Patch Set 11 : Simplify DrawPathEx #

Patch Set 12 : Simplify DrawCosmeticLineEx #

Patch Set 13 : Simplify FillRectEx #

Patch Set 14 : Simplify DrawFillStrokePath, delete dead macros #

Patch Set 15 : Rename Ex functions #

Patch Set 16 : Fix error in patch set 11 #

Patch Set 17 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -316 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +5 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 7 chunks +13 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +7 lines, -5 lines 0 comments Download
M core/fxge/ge/fx_ge_device.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 11 chunks +99 lines, -140 lines 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 8 chunks +38 lines, -61 lines 0 comments Download
M core/fxge/include/fx_dib.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -4 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +90 lines, -77 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +17 lines, -14 lines 0 comments Download

Dependent Patchsets:

Issue 2013023002 Patch 40001

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-26 16:57:12 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-05-26 17:04:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011943004/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011943004/320001
4 years, 7 months ago (2016-05-26 17:53:13 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:04:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #17 (id:320001) as
https://pdfium.googlesource.com/pdfium/+/d3e354a43531eaed87e43d9ff2df4525186e...

Powered by Google App Engine
This is Rietveld 408576698