DevTools: consolidate protocol generators for front-end, backend and type builder.

DevTools: consolidate protocol generators for front-end, backend and type builder.

BUG=580337
Committed: https://crrev.com/21d06c3ce07e3800f769d3395cce1985a733f10a
Cr-Commit-Position: refs/heads/master@{#396629}

[pfeldman, 2016-05-26 01:44:12]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[pfeldman, 2016-05-26 01:44:17]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[commit-bot: I haz the power, 2016-05-26 01:44:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/1

[commit-bot: I haz the power, 2016-05-26 01:56:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 01:56:22]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[dgozman, 2016-05-26 20:55:31]

Looks like this doesn't compile.

https://codereview.chromium.org/2012753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/2012753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/protocol.json:76: "depends": ["Debugger"],
It's called "deps" or "dependencies" in many other places, let's converge?

https://codereview.chromium.org/2012753003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/Frontend.h (right):

https://codereview.chromium.org/2012753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/Frontend.h:15: class
PLATFORM_EXPORT Frontend {
Why don't we generate this one? Why do we even need it?

https://codereview.chromium.org/2012753003/diff/1/third_party/WebKit/Source/p...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
(right):

https://codereview.chromium.org/2012753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:230:
Frontend(FrontendChannel* frontendChannel) : m_frontendChannel(frontendChannel)
{ }
explicit

[pfeldman, 2016-05-27 02:36:18]

PTAL. it did compile - generated files were messing with new regular files w/
same name.

[dgozman, 2016-05-27 05:20:47]

lgtm

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:76: "depends": ["Debugger"],
depends on DOM

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:1217: "domain": "Network",
depends on runtime

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:2249: "domain": "DOM",
depends on runtime

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:2927: "domain": "CSS",
depends on DOM

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:4576: "domain": "LayerTree",
depends on DOM

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:4857: "domain": "Animation",
depends on DOM, runtime

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:5017: "domain":
"Accessibility",
depends on DOM

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
(right):

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:104: if
"depends" in domain:
I think we should either infer this from type usage or enforce it during type
generation

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/2012753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:73: #include
"platform/inspector_protocol/DispatcherBase.h"
I think we may not even use it here.

[pfeldman, 2016-05-27 06:01:47]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 06:02:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/40001

[commit-bot: I haz the power, 2016-05-27 06:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 06:18:22]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[pfeldman, 2016-05-27 15:01:53]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-27 15:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2012753003/#ps60001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-05-27 15:02:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/60001

[commit-bot: I haz the power, 2016-05-27 15:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 15:13:57]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[pfeldman, 2016-05-27 19:28:06]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-27 19:28:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2012753003/#ps80001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-05-27 19:28:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/80001

[commit-bot: I haz the power, 2016-05-27 19:43:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 19:43:04]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[pfeldman, 2016-05-27 21:19:36]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-27 21:19:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2012753003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-27 21:19:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/100001

[commit-bot: I haz the power, 2016-05-27 22:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 22:17:24]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[pfeldman, 2016-05-27 23:01:56]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-27 23:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2012753003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-05-27 23:02:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/120001

[commit-bot: I haz the power, 2016-05-28 00:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 00:03:46]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[pfeldman, 2016-05-28 00:08:28]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-28 00:08:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2012753003/#ps140001
(title: "win bot speculative fix")

[commit-bot: I haz the power, 2016-05-28 00:08:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/140001

[pfeldman, 2016-05-28 00:38:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-28 00:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2012753003/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-05-28 00:39:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012753003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012753003/160001

[commit-bot: I haz the power, 2016-05-28 02:44:04]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-05-28 02:45:18]

Description was changed from

==========
DevTools: consolidate protocol generators for front-end, backend and type
builder.

BUG=580337
==========

to

==========
DevTools: consolidate protocol generators for front-end, backend and type
builder.

BUG=580337

Committed: https://crrev.com/21d06c3ce07e3800f769d3395cce1985a733f10a
Cr-Commit-Position: refs/heads/master@{#396629}
==========

[commit-bot: I haz the power, 2016-05-28 02:45:20]

Patchset 9 (id:??) landed as
https://crrev.com/21d06c3ce07e3800f769d3395cce1985a733f10a
Cr-Commit-Position: refs/heads/master@{#396629}