Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2012753003: DevTools: consolidate protocol generators for front-end, backend and type builder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
index 9ff665e6a37246e92005f94c42c8e3aa1b2261e1..c77dea4a388b7e5f17baa233e6e4cfb68beffc1e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
@@ -32,9 +32,8 @@
#define V8RuntimeAgentImpl_h
#include "platform/inspector_protocol/Allocator.h"
-#include "platform/inspector_protocol/Backend.h"
-#include "platform/inspector_protocol/Frontend.h"
#include "platform/inspector_protocol/String16.h"
+#include "platform/inspector_protocol/TypeBuilder.h"
#include <v8.h>
@@ -55,7 +54,7 @@ using protocol::Maybe;
class V8RuntimeAgentImpl : public protocol::Runtime::Backend {
PROTOCOL_DISALLOW_COPY(V8RuntimeAgentImpl);
public:
- V8RuntimeAgentImpl(V8InspectorSessionImpl*, protocol::Runtime::Frontend*, protocol::DictionaryValue* state);
+ V8RuntimeAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*, protocol::DictionaryValue* state);
~V8RuntimeAgentImpl() override;
void restore();
@@ -120,7 +119,7 @@ public:
private:
V8InspectorSessionImpl* m_session;
protocol::DictionaryValue* m_state;
- protocol::Runtime::Frontend* m_frontend;
+ protocol::Runtime::Frontend m_frontend;
V8DebuggerImpl* m_debugger;
bool m_enabled;
protocol::HashMap<String16, std::unique_ptr<v8::Global<v8::Script>>> m_compiledScripts;

Powered by Google App Engine
This is Rietveld 408576698