Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2012753003: DevTools: consolidate protocol generators for front-end, backend and type builder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
index c72a1c1f4acf491cac716b98b65a6b33c9620e1f..dc45b11875ec863bec1b1723311002cc743e717e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
@@ -56,10 +56,10 @@ static bool hasInternalError(ErrorString* errorString, bool hasError)
return hasError;
}
-V8RuntimeAgentImpl::V8RuntimeAgentImpl(V8InspectorSessionImpl* session, protocol::Runtime::Frontend* frontend, protocol::DictionaryValue* state)
+V8RuntimeAgentImpl::V8RuntimeAgentImpl(V8InspectorSessionImpl* session, protocol::FrontendChannel* FrontendChannel, protocol::DictionaryValue* state)
: m_session(session)
, m_state(state)
- , m_frontend(frontend)
+ , m_frontend(FrontendChannel)
, m_debugger(session->debugger())
, m_enabled(false)
{
@@ -347,7 +347,7 @@ void V8RuntimeAgentImpl::restore()
{
if (!m_state->booleanProperty(V8RuntimeAgentImplState::runtimeEnabled, false))
return;
- m_frontend->executionContextsCleared();
+ m_frontend.executionContextsCleared();
ErrorString error;
enable(&error);
if (m_state->booleanProperty(V8RuntimeAgentImplState::customObjectFormatterEnabled, false))
@@ -384,7 +384,7 @@ void V8RuntimeAgentImpl::reset()
for (auto& idContext : *contexts)
idContext.second->setReported(false);
}
- m_frontend->executionContextsCleared();
+ m_frontend.executionContextsCleared();
}
}
@@ -399,21 +399,21 @@ void V8RuntimeAgentImpl::reportExecutionContextCreated(InspectedContext* context
.setName(context->humanReadableName())
.setOrigin(context->origin())
.setFrameId(context->frameId()).build();
- m_frontend->executionContextCreated(std::move(description));
+ m_frontend.executionContextCreated(std::move(description));
}
void V8RuntimeAgentImpl::reportExecutionContextDestroyed(InspectedContext* context)
{
if (m_enabled && context->isReported()) {
context->setReported(false);
- m_frontend->executionContextDestroyed(context->contextId());
+ m_frontend.executionContextDestroyed(context->contextId());
}
}
void V8RuntimeAgentImpl::inspect(std::unique_ptr<protocol::Runtime::RemoteObject> objectToInspect, std::unique_ptr<protocol::DictionaryValue> hints)
{
if (m_enabled)
- m_frontend->inspectRequested(std::move(objectToInspect), std::move(hints));
+ m_frontend.inspectRequested(std::move(objectToInspect), std::move(hints));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698