[Findit] Set use_analyze to False if the try job doesn't run linearly.

[Findit] Set use_analyze to False if the try job doesn't run linearly.

BUG=614561
Committed: https://chromium.googlesource.com/chromium/tools/build/+/878a7ed92a85e773ed8cbd7e43dedbb7977b2044

[chanli, 2016-05-25 00:53:08]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-05-25 00:53:08]

PTAL

[stgao, 2016-05-25 00:57:52]

https://codereview.chromium.org/2011733002/diff/1/scripts/slave/recipes/findi...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/2011733002/diff/1/scripts/slave/recipes/findi...
scripts/slave/recipes/findit/chromium/test.py:264: use_analyze = False
what if the only suspected revision is with index 0?

I'd just do:

use_analyze = not bool(suspected_revision_index)

[stgao, 2016-05-25 00:58:08]

lgtm after comment is addressed.

[chanli, 2016-05-25 00:59:54]

https://codereview.chromium.org/2011733002/diff/1/scripts/slave/recipes/findi...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/2011733002/diff/1/scripts/slave/recipes/findi...
scripts/slave/recipes/findit/chromium/test.py:264: use_analyze = False
On 2016/05/25 00:57:52, stgao wrote:
> what if the only suspected revision is with index 0?
> 
> I'd just do:
> 
> use_analyze = not bool(suspected_revision_index)

If the only suspected revision is with index 0, that means we will fall back to
linear, right? And in that case we should keep use_analyze?

[stgao, 2016-05-25 01:01:04]

On 2016/05/25 00:59:54, chanli wrote:
>
https://codereview.chromium.org/2011733002/diff/1/scripts/slave/recipes/findi...
> File scripts/slave/recipes/findit/chromium/test.py (right):
> 
>
https://codereview.chromium.org/2011733002/diff/1/scripts/slave/recipes/findi...
> scripts/slave/recipes/findit/chromium/test.py:264: use_analyze = False
> On 2016/05/25 00:57:52, stgao wrote:
> > what if the only suspected revision is with index 0?
> > 
> > I'd just do:
> > 
> > use_analyze = not bool(suspected_revision_index)
> 
> If the only suspected revision is with index 0, that means we will fall back
to
> linear, right? And in that case we should keep use_analyze?

ah, you are right.
lgtm

[lijeffrey, 2016-05-25 02:01:12]

lgtm

[chanli, 2016-05-25 02:07:43]

The CQ bit was checked by chanli@chromium.org

[commit-bot: I haz the power, 2016-05-25 02:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011733002/1

[commit-bot: I haz the power, 2016-05-25 02:11:46]

Description was changed from

==========
[Findit] Set use_analyze to False if the try job doesn't run linearly.

BUG=614561
==========

to

==========
[Findit] Set use_analyze to False if the try job doesn't run linearly.

BUG=614561

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/878a7ed92a85e773ed8c...
==========

[commit-bot: I haz the power, 2016-05-25 02:11:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/878a7ed92a85e773ed8c...