[Findit] Set use_analyze to False if the try job doesn't run linearly.

scripts/slave/recipes/findit/chromium/test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import json
 
 from recipe_engine.config import Dict
 from recipe_engine.config import List
 from recipe_engine.config import Single
@@ skipping 242 matching lines @@
   # [[None, r0], [r1, r2, r3], [r4, r5, r6]]
   if suspected_revision_index:
     # If there are consecutive revisions being suspected, include them
     # in the same sub_range by only saving the oldest revision.
     suspected_revision_index = [i for i in suspected_revision_index
                                 if i - 1 not in suspected_revision_index]
     sub_ranges = []
     remaining_revisions = revisions_to_check[:]
     for index in sorted(suspected_revision_index, reverse=True):
       if index > 0:
+        # try job will not run linearly, sets use_analyze to False.
+        use_analyze = False

[stgao, 2016/05/25 00:57:52]

what if the only suspected revision is with index 0?

I'd just do:

use_analyze = not bool(suspected_revision_index)

[chanli, 2016/05/25 00:59:54]

If the only suspected revision is with index 0, that means we will fall back to
linear, right? And in that case we should keep use_analyze?

         sub_ranges.append(remaining_revisions[index - 1:])
         remaining_revisions = remaining_revisions[:index - 1]
     # None is a placeholder for the last known good revision.
     sub_ranges.append([None] + remaining_revisions)
   else:
     # Treats the entire regression range as a single sub-range.
     sub_ranges = [[None] + revisions_to_check]
 
   test_results = {}
   try_job_metadata = {
@@ skipping 780 matching lines @@
       api.override_step_data(
           'test r4.gl_tests (r4) on Mac-10.9',
           simulated_gtest_output(failed_test_names=['Test.One'])) +
       api.override_step_data(
           'test r2.gl_tests (r2) on Mac-10.9',
           simulated_gtest_output(passed_test_names=['Test.One'])) +
       api.override_step_data(
           'test r3.gl_tests (r3) on Mac-10.9',
           simulated_gtest_output(passed_test_names=['Test.One']))
   )
+
+  yield (
+      api.test('use_analyze_set_to_False_for_non_linear_try_job') +
+      props(
+          {'gl_tests': ['Test.One']}, 'mac', 'Mac10.9 Tests', use_analyze=True,
+           good_revision='r0', bad_revision='r6', suspected_revisions=['r3']) +
+      api.override_step_data('test r2.read test spec', api.json.output({
+          'Mac10.9 Tests': {
+              'gtest_tests': [
+                  {
+                      'test': 'gl_tests',
+                      'swarming': {'can_use_on_swarming_builders': True},
+                  },
+              ],
+          },
+      })) +
+      api.override_step_data('test r3.read test spec', api.json.output({
+          'Mac10.9 Tests': {
+              'gtest_tests': [
+                  {
+                      'test': 'gl_tests',
+                      'swarming': {'can_use_on_swarming_builders': True},
+                  },
+              ],
+          },
+      })) +
+      api.override_step_data(
+          'git commits in range',
+          api.raw_io.stream_output(
+              '\n'.join('r%d' % i for i in reversed(range(1, 7))))) +
+      api.override_step_data(
+          'test r2.gl_tests (r2) on Mac-10.9',
+          simulated_gtest_output(passed_test_names=['Test.One'])) +
+      api.override_step_data(
+          'test r3.gl_tests (r3) on Mac-10.9',
+          simulated_gtest_output(failed_test_names=['Test.One']))
+  )