Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: scripts/slave/recipes/findit/chromium/test.py

Issue 2011733002: [Findit] Set use_analyze to False if the try job doesn't run linearly. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/findit/chromium/test.py
diff --git a/scripts/slave/recipes/findit/chromium/test.py b/scripts/slave/recipes/findit/chromium/test.py
index 13f660f2ea74676a6f68fc4e6892b0fe8afd08fc..dc2f10deba813ed362dab94755b3015e96ae415a 100644
--- a/scripts/slave/recipes/findit/chromium/test.py
+++ b/scripts/slave/recipes/findit/chromium/test.py
@@ -260,6 +260,8 @@ def RunSteps(api, target_mastername, target_testername, good_revision,
remaining_revisions = revisions_to_check[:]
for index in sorted(suspected_revision_index, reverse=True):
if index > 0:
+ # try job will not run linearly, sets use_analyze to False.
+ use_analyze = False
stgao 2016/05/25 00:57:52 what if the only suspected revision is with index
chanli 2016/05/25 00:59:54 If the only suspected revision is with index 0, th
sub_ranges.append(remaining_revisions[index - 1:])
remaining_revisions = remaining_revisions[:index - 1]
# None is a placeholder for the last known good revision.
@@ -1060,3 +1062,40 @@ def GenTests(api):
'test r3.gl_tests (r3) on Mac-10.9',
simulated_gtest_output(passed_test_names=['Test.One']))
)
+
+ yield (
+ api.test('use_analyze_set_to_False_for_non_linear_try_job') +
+ props(
+ {'gl_tests': ['Test.One']}, 'mac', 'Mac10.9 Tests', use_analyze=True,
+ good_revision='r0', bad_revision='r6', suspected_revisions=['r3']) +
+ api.override_step_data('test r2.read test spec', api.json.output({
+ 'Mac10.9 Tests': {
+ 'gtest_tests': [
+ {
+ 'test': 'gl_tests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ })) +
+ api.override_step_data('test r3.read test spec', api.json.output({
+ 'Mac10.9 Tests': {
+ 'gtest_tests': [
+ {
+ 'test': 'gl_tests',
+ 'swarming': {'can_use_on_swarming_builders': True},
+ },
+ ],
+ },
+ })) +
+ api.override_step_data(
+ 'git commits in range',
+ api.raw_io.stream_output(
+ '\n'.join('r%d' % i for i in reversed(range(1, 7))))) +
+ api.override_step_data(
+ 'test r2.gl_tests (r2) on Mac-10.9',
+ simulated_gtest_output(passed_test_names=['Test.One'])) +
+ api.override_step_data(
+ 'test r3.gl_tests (r3) on Mac-10.9',
+ simulated_gtest_output(failed_test_names=['Test.One']))
+ )
« no previous file with comments | « no previous file | scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698