Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2011653004: Remove obsolete fields in quic_protocol and their current usage in QUIC. Reorders QuicAckFrame fie… (Closed)

Created:
4 years, 7 months ago by Fan Yang
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@122721477
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete fields in quic_protocol and their current usage in QUIC. Reorders QuicAckFrame fields based on ClassLayoutOptimizer. No functional change. Merge internal change: 122750844 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -866 lines) Patch
M net/net.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D net/quic/quic_fec_group.h View 1 chunk +0 lines, -76 lines 0 comments Download
D net/quic/quic_fec_group.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D net/quic/quic_fec_group_interface.h View 1 chunk +0 lines, -84 lines 0 comments Download
D net/quic/quic_fec_group_interface.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D net/quic/quic_fec_group_test.cc View 1 chunk +0 lines, -331 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_framer_test.cc View 32 chunks +0 lines, -40 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.h View 11 chunks +13 lines, -30 lines 0 comments Download
M net/quic/quic_protocol.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 8 chunks +0 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Fan Yang
4 years, 7 months ago (2016-05-25 22:20:11 UTC) #2
Ryan Hamilton
4 years, 7 months ago (2016-05-25 22:31:17 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698